git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] range-diff: fix a crash in parsing git-log output

From
Taylor Blau <me@ttaylorr.com>
Date
Apr 16, 2020, 01:07 UTC
Message-ID
<20200416010734.GE36156@syl.local>
In-Reply-To
<pull.760.v2.git.git.1586982745.gitgitgadget@gmail.com>
Hi Vasil,
Thanks for sending a v2. This all looks good to me.
On Wed, Apr 15, 2020 at 08:32:23PM +0000, Vasil Dimov via GitGitGadget wrote:
Show 23 quoted lines
>  * override a possibly user-customized format.pretty that would render git
>    log output unparsable by git range-diff
>
>
>  * don't use negative string precision, e.g. "%.*s", -5, "foo"
>
>
>
> Changes since v1:
>
>  * Fixed a typo in the commit message (found by Taylor Blau)
>
> Vasil Dimov (2):
>   range-diff: fix a crash in parsing git-log output
>   range-diff: avoid negative string precision
>
>  range-diff.c          | 18 +++++++++++++++++-
>  t/t3206-range-diff.sh | 10 ++++++++++
>  2 files changed, 27 insertions(+), 1 deletion(-)
>
> [snip]
> --
> gitgitgadget
  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

Previous: Vasil Dimov via GitGitGadget
Message 15 of 15 in “range-diff: fix a crash in parsing git-log output”
  1. 0/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  2. 2/2 range-diff: avoid negative string precisionVasil Dimov via GitGitGadget, Apr 15, 2020
  3. Taylor BlauApr 15, 2020
  4. Vasil DimovApr 15, 2020
  5. 1/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  6. Junio C HamanoApr 15, 2020
  7. Vasil DimovApr 15, 2020
  8. Jeff KingApr 15, 2020
  9. Taylor BlauApr 15, 2020
  10. Jeff KingApr 15, 2020
  11. Taylor BlauApr 15, 2020
  12. 0/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  13. 1/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  14. 2/2 range-diff: avoid negative string precisionVasil Dimov via GitGitGadget, Apr 15, 2020
  15. Taylor BlauApr 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.