git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] range-diff: fix a crash in parsing git-log output

From
Vasil Dimov via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 15, 2020, 20:32 UTC
Message-ID
<pull.760.v2.git.git.1586982745.gitgitgadget@gmail.com>
In-Reply-To
<pull.760.git.git.1586960921.gitgitgadget@gmail.com>
 * override a possibly user-customized format.pretty that would render git
   log output unparsable by git range-diff
   
   
 * don't use negative string precision, e.g. "%.*s", -5, "foo"
   
   
Changes since v1:
 * Fixed a typo in the commit message (found by Taylor Blau)
Vasil Dimov (2):
  range-diff: fix a crash in parsing git-log output
  range-diff: avoid negative string precision
 range-diff.c          | 18 +++++++++++++++++-
 t/t3206-range-diff.sh | 10 ++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)
base-commit: de49261b050d9cd8ec73842356077bc5b606640f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-760%2Fvasild%2Frange-diff-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-760/vasild/range-diff-v2
Pull-Request: https://github.com/git/git/pull/760
Range-diff vs v1:
 1:  2375e34100e = 1:  2375e34100e range-diff: fix a crash in parsing git-log output
 2:  b3384880c72 ! 2:  72fddcff554 range-diff: avoid negative string precision
     @@ Metadata
       ## Commit message ##
          range-diff: avoid negative string precision
      
     -    If the supplied integer for "precisoin" is negative in
     +    If the supplied integer for "precision" is negative in
          `"%.*s", len, line` then it is ignored. So the current code is
          equivalent to just `"%s", line` because it is executed only if
          `len` is negative.
-- 
gitgitgadget
Previous: Taylor BlauNext: Vasil Dimov via GitGitGadget
Message 12 of 15 in “range-diff: fix a crash in parsing git-log output”
  1. 0/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  2. 2/2 range-diff: avoid negative string precisionVasil Dimov via GitGitGadget, Apr 15, 2020
  3. Taylor BlauApr 15, 2020
  4. Vasil DimovApr 15, 2020
  5. 1/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  6. Junio C HamanoApr 15, 2020
  7. Vasil DimovApr 15, 2020
  8. Jeff KingApr 15, 2020
  9. Taylor BlauApr 15, 2020
  10. Jeff KingApr 15, 2020
  11. Taylor BlauApr 15, 2020
  12. 0/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  13. 1/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  14. 2/2 range-diff: avoid negative string precisionVasil Dimov via GitGitGadget, Apr 15, 2020
  15. Taylor BlauApr 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.