git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] range-diff: fix a crash in parsing git-log output

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 15, 2020, 15:31 UTC
Message-ID
<xmqqsgh47okk.fsf@gitster.c.googlers.com>
In-Reply-To
<2375e34100e571f9c3ce658d28aba6648fba18a6.1586960921.git.gitgitgadget@gmail.com>
"Vasil Dimov via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> From: Vasil Dimov <vd@FreeBSD.org>
>
> `git range-diff` calls `git log` internally and tries to parse its
> output. But `git log` output can be customized by the user in their
> git config and for certain configurations either an error will be
> returned by `git range-diff` or it will crash.
>
> To fix this explicitly set the output format of the internally
> executed `git log` with `--pretty=medium`. Because that cancels
> `--notes`, add explicitly `--notes` at the end.
Good finding.

Shouldn't we also disable customizations that come from the configuration variables like diff.external, diff.<driver>.command?

Thanks.
Previous: Vasil Dimov via GitGitGadgetNext: Vasil Dimov
Message 6 of 15 in “range-diff: fix a crash in parsing git-log output”
  1. 0/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  2. 2/2 range-diff: avoid negative string precisionVasil Dimov via GitGitGadget, Apr 15, 2020
  3. Taylor BlauApr 15, 2020
  4. Vasil DimovApr 15, 2020
  5. 1/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  6. Junio C HamanoApr 15, 2020
  7. Vasil DimovApr 15, 2020
  8. Jeff KingApr 15, 2020
  9. Taylor BlauApr 15, 2020
  10. Jeff KingApr 15, 2020
  11. Taylor BlauApr 15, 2020
  12. 0/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  13. 1/2 range-diff: fix a crash in parsing git-log outputVasil Dimov via GitGitGadget, Apr 15, 2020
  14. 2/2 range-diff: avoid negative string precisionVasil Dimov via GitGitGadget, Apr 15, 2020
  15. Taylor BlauApr 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.