From: Taylor Blau Date: Thu, 16 Apr 2020 01:07:34 GMT Subject: Re: [PATCH v2 0/2] range-diff: fix a crash in parsing git-log output Message-ID: <20200416010734.GE36156@syl.local> In-Reply-To: Hi Vasil, Thanks for sending a v2. This all looks good to me. On Wed, Apr 15, 2020 at 08:32:23PM +0000, Vasil Dimov via GitGitGadget wrote: > * override a possibly user-customized format.pretty that would render git > log output unparsable by git range-diff > > > * don't use negative string precision, e.g. "%.*s", -5, "foo" > > > > Changes since v1: > > * Fixed a typo in the commit message (found by Taylor Blau) > > Vasil Dimov (2): > range-diff: fix a crash in parsing git-log output > range-diff: avoid negative string precision > > range-diff.c | 18 +++++++++++++++++- > t/t3206-range-diff.sh | 10 ++++++++++ > 2 files changed, 27 insertions(+), 1 deletion(-) > > [snip] > -- > gitgitgadget Reviewed-by: Taylor Blau Thanks, Taylor