git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: bug? illegal text in commit log

From
PYPratyush Yadav <p.yadav@ti.com>
Date
Feb 7, 2020, 11:02 UTC
Message-ID
<20200207110216.ppf5aksfkam54bip@ti.com>
In-Reply-To
<xmqqd0arfyw8.fsf@gitster-ct.c.googlers.com>
On 06/02/20 08:45AM, Junio C Hamano wrote:
Show 8 quoted lines
> René Scharfe <l.s.r@web.de> writes:
> 
> > Like a Lines: header specifying the number of lines in the commit message?
> 
> The only part of the workflow that can count the number reliably is
> format-patch.  But the output of format-patch is designed to be
> edited further, and expecting users to adjust the number when they
> make such an edit is a bit too much.
I haven't thought this through, but I'll throw the idea out anyway:

How about counting lines in the diff (the one generated by format-patch, not the one in the commit message) instead of lines in the commit message? This way, the bottom n lines in the mail (barring the signature) are the diff contents.

I personally have often edited the commit message and added comments below the '---' line in the patches output by format-patch, but I rarely ever manually edit the diff. It is just really easy to corrupt the patch when you manually edit it.

-- 
Regards,
Pratyush Yadav
Previous: Michael S. TsirkinNext: René Scharfe
Message 12 of 14 in “bug? illegal text in commit log”
  1. Michael S. TsirkinFeb 4, 2020
  2. René ScharfeFeb 4, 2020
  3. Junio C HamanoFeb 4, 2020
  4. Michael S. TsirkinFeb 6, 2020
  5. Junio C HamanoFeb 6, 2020
  6. Junio C HamanoFeb 6, 2020
  7. René ScharfeFeb 6, 2020
  8. Junio C HamanoFeb 7, 2020
  9. René ScharfeFeb 7, 2020
  10. Jeff KingFeb 12, 2020
  11. Michael S. TsirkinFeb 6, 2020
  12. Pratyush YadavFeb 7, 2020
  13. René ScharfeFeb 7, 2020
  14. Junio C HamanoFeb 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.