Re: bug? illegal text in commit log
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 6, 2020, 16:45 UTC
- Message-ID
- <xmqqd0arfyw8.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <b005193f-24b7-7b6f-f3dc-c7a98db14ed7@web.de>
René Scharfe <l.s.r@web.de> writes:
> Like a Lines: header specifying the number of lines in the commit message?
The only part of the workflow that can count the number reliably is format-patch. But the output of format-patch is designed to be edited further, and expecting users to adjust the number when they make such an edit is a bit too much.
As nobody in the discussion seem to care any e-mail source other than format-patch, we may probably be able to teach mailinfo that
* the first line that - begins with "diff " or "Index", or - is "---" (and nothing else on the line) signals that the line no longer is part of the log
* but if it finds a line that begins with "diff --git" (or optionally just "diff "), do not blindly assume that is the end of the log, and instead try to find the first "---" line. If there isn't any "---", then take that "diff" line the beginning of the patch, but if there is, "---" is the end of the message.
The latter rule is the new one. And there is no need to change format-patch output.