From: Pratyush Yadav <p.yadav@ti.com>
Date: Fri, 07 Feb 2020 11:02:16 GMT
Subject: Re: bug? illegal text in commit log
Message-ID: <20200207110216.ppf5aksfkam54bip@ti.com>
In-Reply-To: <xmqqd0arfyw8.fsf@gitster-ct.c.googlers.com>

On 06/02/20 08:45AM, Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
> 
> > Like a Lines: header specifying the number of lines in the commit message?
> 
> The only part of the workflow that can count the number reliably is
> format-patch.  But the output of format-patch is designed to be
> edited further, and expecting users to adjust the number when they
> make such an edit is a bit too much.

I haven't thought this through, but I'll throw the idea out anyway:

How about counting lines in the diff (the one generated by format-patch, 
not the one in the commit message) instead of lines in the commit 
message? This way, the bottom n lines in the mail (barring the 
signature) are the diff contents.

I personally have often edited the commit message and added comments 
below the '---' line in the patches output by format-patch, but I rarely 
ever manually edit the diff. It is just really easy to corrupt the patch 
when you manually edit it.

-- 
Regards,
Pratyush Yadav