Re: bug? illegal text in commit log
On Thu, Feb 06, 2020 at 08:45:11AM -0800, Junio C Hamano wrote:
Show 25 quoted lines
> René Scharfe <l.s.r@web.de> writes:
>
> > Like a Lines: header specifying the number of lines in the commit message?
>
> The only part of the workflow that can count the number reliably is
> format-patch. But the output of format-patch is designed to be
> edited further, and expecting users to adjust the number when they
> make such an edit is a bit too much.
>
> As nobody in the discussion seem to care any e-mail source other
> than format-patch, we may probably be able to teach mailinfo that
>
> * the first line that
> - begins with "diff " or "Index", or
> - is "---" (and nothing else on the line)
> signals that the line no longer is part of the log
>
> * but if it finds a line that begins with "diff --git" (or
> optionally just "diff "), do not blindly assume that is the end
> of the log, and instead try to find the first "---" line. If
> there isn't any "---", then take that "diff" line the beginning
> of the patch, but if there is, "---" is the end of the message.
>
> The latter rule is the new one. And there is no need to change
> format-patch output.
sounds good to me. any takers?