git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 07/21] t4013: make test hash independent

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 7, 2020, 00:52 UTC
Message-ID
<20200207005254.1495851-8-sandals@crustytoothpaste.net>
In-Reply-To
<20200207005254.1495851-1-sandals@crustytoothpaste.net>

This test produces a large number of diff formats and compares the output with test files that have content specific to SHA-1. Since we are more interested in the format of the diffs, and not their specific values, which are tested elsewhere, add a function which uses sed to transform these specific object IDs into generic ones of the right size, which we can then compare.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t4013-diff-various.sh | 44 +++++++++++++++++++++++++++++++++++------
 1 file changed, 38 insertions(+), 6 deletions(-)
diff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh
index 5ac94b390d..dde3f11fec 100755
--- a/t/t4013-diff-various.sh
+++ b/t/t4013-diff-various.sh
@@ -120,6 +120,30 @@ test_expect_success setup '
 +*++ [initial] Initial
 EOF
 
+process_diffs () {
+	_x04="[0-9a-f][0-9a-f][0-9a-f][0-9a-f]" &&
+	_x07="$_x05[0-9a-f][0-9a-f]" &&
+	sed -e "s/$OID_REGEX/$ZERO_OID/g" \
+	    -e "s/From $_x40 /From $ZERO_OID /" \
+	    -e "s/from $_x40)/from $ZERO_OID)/" \
+	    -e "s/commit $_x40\$/commit $ZERO_OID/" \
+	    -e "s/commit $_x40 (/commit $ZERO_OID (/" \
+	    -e "s/$_x40 $_x40 $_x40/$ZERO_OID $ZERO_OID $ZERO_OID/" \
+	    -e "s/$_x40 $_x40 /$ZERO_OID $ZERO_OID /" \
+	    -e "s/^$_x40 $_x40$/$ZERO_OID $ZERO_OID/" \
+	    -e "s/^$_x40 /$ZERO_OID /" \
+	    -e "s/^$_x40$/$ZERO_OID/" \
+	    -e "s/$_x07\.\.$_x07/fffffff..fffffff/g" \
+	    -e "s/$_x07,$_x07\.\.$_x07/fffffff,fffffff..fffffff/g" \
+	    -e "s/$_x07 $_x07 $_x07/fffffff fffffff fffffff/g" \
+	    -e "s/$_x07 $_x07 /fffffff fffffff /g" \
+	    -e "s/Merge: $_x07 $_x07/Merge: fffffff fffffff/g" \
+	    -e "s/$_x07\.\.\./fffffff.../g" \
+	    -e "s/ $_x04\.\.\./ ffff.../g" \
+	    -e "s/ $_x04/ ffff/g" \
+	    "$1"
+}
+
 V=$(git version | sed -e 's/^git version //' -e 's/\./\\./g')
 while read magic cmd
 do
@@ -158,13 +182,15 @@ do
 		} >"$actual" &&
 		if test -f "$expect"
 		then
+			process_diffs "$actual" >actual &&
+			process_diffs "$expect" >expect &&
 			case $cmd in
 			*format-patch* | *-stat*)
-				test_i18ncmp "$expect" "$actual";;
+				test_i18ncmp expect actual;;
 			*)
-				test_cmp "$expect" "$actual";;
+				test_cmp expect actual;;
 			esac &&
-			rm -f "$actual"
+			rm -f "$actual" actual expect
 		else
 			# this is to help developing new tests.
 			cp "$actual" "$expect"
@@ -383,16 +409,22 @@ test_expect_success 'log -S requires an argument' '
 test_expect_success 'diff --cached on unborn branch' '
 	echo ref: refs/heads/unborn >.git/HEAD &&
 	git diff --cached >result &&
-	test_cmp "$TEST_DIRECTORY/t4013/diff.diff_--cached" result
+	process_diffs result >actual &&
+	process_diffs "$TEST_DIRECTORY/t4013/diff.diff_--cached" >expected &&
+	test_cmp expected actual
 '
 
 test_expect_success 'diff --cached -- file on unborn branch' '
 	git diff --cached -- file0 >result &&
-	test_cmp "$TEST_DIRECTORY/t4013/diff.diff_--cached_--_file0" result
+	process_diffs result >actual &&
+	process_diffs "$TEST_DIRECTORY/t4013/diff.diff_--cached_--_file0" >expected &&
+	test_cmp expected actual
 '
 test_expect_success 'diff --line-prefix with spaces' '
 	git diff --line-prefix="| | | " --cached -- file0 >result &&
-	test_cmp "$TEST_DIRECTORY/t4013/diff.diff_--line-prefix_--cached_--_file0" result
+	process_diffs result >actual &&
+	process_diffs "$TEST_DIRECTORY/t4013/diff.diff_--line-prefix_--cached_--_file0" >expected &&
+	test_cmp expected actual
 '
 
 test_expect_success 'diff-tree --stdin with log formatting' '
Previous: brian m. carlsonNext: brian m. carlson
Message 5 of 22 in “SHA-256 test fixes, part 8”
  1. 00/21 SHA-256 test fixes, part 8brian m. carlson, Feb 7, 2020
  2. 01/21 t/lib-pack: support SHA-256brian m. carlson, Feb 7, 2020
  3. 02/21 t3206: make hash size independentbrian m. carlson, Feb 7, 2020
  4. 03/21 t3308: make test work with SHA-256brian m. carlson, Feb 7, 2020
  5. 07/21 t4013: make test hash independentbrian m. carlson, Feb 7, 2020
  6. 04/21 t3309: make test work with SHA-256brian m. carlson, Feb 7, 2020
  7. 06/21 t3311: make test work with SHA-256brian m. carlson, Feb 7, 2020
  8. 05/21 t3310: make test work with SHA-256brian m. carlson, Feb 7, 2020
  9. 10/21 t4060: make test work with SHA-256brian m. carlson, Feb 7, 2020
  10. 11/21 t5302: make hash size independentbrian m. carlson, Feb 7, 2020
  11. 15/21 t5515: make test hash independentbrian m. carlson, Feb 7, 2020
  12. 20/21 t6006: make hash size independentbrian m. carlson, Feb 7, 2020
  13. 18/21 t5703: make test work with SHA-256brian m. carlson, Feb 7, 2020
  14. 21/21 t6024: update for SHA-256brian m. carlson, Feb 7, 2020
  15. 14/21 t5321: make test hash independentbrian m. carlson, Feb 7, 2020
  16. 19/21 t6000: abstract away SHA-1-specific constantsbrian m. carlson, Feb 7, 2020
  17. 17/21 t5607: make hash size independentbrian m. carlson, Feb 7, 2020
  18. 13/21 t5313: make test hash independentbrian m. carlson, Feb 7, 2020
  19. 16/21 t5318: update for SHA-256brian m. carlson, Feb 7, 2020
  20. 12/21 t5309: make test hash independentbrian m. carlson, Feb 7, 2020
  21. 09/21 t4211: add test cases for SHA-256brian m. carlson, Feb 7, 2020
  22. 08/21 t4211: move SHA-1-specific test cases into a directorybrian m. carlson, Feb 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.