git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 19/21] t6000: abstract away SHA-1-specific constants

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 7, 2020, 00:52 UTC
Message-ID
<20200207005254.1495851-20-sandals@crustytoothpaste.net>
In-Reply-To
<20200207005254.1495851-1-sandals@crustytoothpaste.net>

Adjust the test so that it computes variables for object IDs instead of using hard-coded hashes.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t6000-rev-list-misc.sh | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/t/t6000-rev-list-misc.sh b/t/t6000-rev-list-misc.sh
index b8cf82349b..a0baf9ee43 100755
--- a/t/t6000-rev-list-misc.sh
+++ b/t/t6000-rev-list-misc.sh
@@ -104,13 +104,16 @@ test_expect_success 'rev-list can show index objects' '
 	#   - we do not show the root tree; since we updated the index, it
 	#     does not have a valid cache tree
 	#
-	cat >expect <<-\EOF &&
-	8e4020bb5a8d8c873b25de15933e75cc0fc275df one
-	d9d3a7417b9605cfd88ee6306b28dadc29e6ab08 only-in-index
-	9200b628cf9dc883a85a7abc8d6e6730baee589c two
-	EOF
 	echo only-in-index >only-in-index &&
 	test_when_finished "git reset --hard" &&
+	rev1=$(git rev-parse HEAD:one) &&
+	rev2=$(git rev-parse HEAD:two) &&
+	revi=$(git hash-object only-in-index) &&
+	cat >expect <<-EOF &&
+	$rev1 one
+	$revi only-in-index
+	$rev2 two
+	EOF
 	git add only-in-index &&
 	git rev-list --objects --indexed-objects >actual &&
 	test_cmp expect actual
Previous: brian m. carlsonNext: brian m. carlson
Message 16 of 22 in “SHA-256 test fixes, part 8”
  1. 00/21 SHA-256 test fixes, part 8brian m. carlson, Feb 7, 2020
  2. 01/21 t/lib-pack: support SHA-256brian m. carlson, Feb 7, 2020
  3. 02/21 t3206: make hash size independentbrian m. carlson, Feb 7, 2020
  4. 03/21 t3308: make test work with SHA-256brian m. carlson, Feb 7, 2020
  5. 07/21 t4013: make test hash independentbrian m. carlson, Feb 7, 2020
  6. 04/21 t3309: make test work with SHA-256brian m. carlson, Feb 7, 2020
  7. 06/21 t3311: make test work with SHA-256brian m. carlson, Feb 7, 2020
  8. 05/21 t3310: make test work with SHA-256brian m. carlson, Feb 7, 2020
  9. 10/21 t4060: make test work with SHA-256brian m. carlson, Feb 7, 2020
  10. 11/21 t5302: make hash size independentbrian m. carlson, Feb 7, 2020
  11. 15/21 t5515: make test hash independentbrian m. carlson, Feb 7, 2020
  12. 20/21 t6006: make hash size independentbrian m. carlson, Feb 7, 2020
  13. 18/21 t5703: make test work with SHA-256brian m. carlson, Feb 7, 2020
  14. 21/21 t6024: update for SHA-256brian m. carlson, Feb 7, 2020
  15. 14/21 t5321: make test hash independentbrian m. carlson, Feb 7, 2020
  16. 19/21 t6000: abstract away SHA-1-specific constantsbrian m. carlson, Feb 7, 2020
  17. 17/21 t5607: make hash size independentbrian m. carlson, Feb 7, 2020
  18. 13/21 t5313: make test hash independentbrian m. carlson, Feb 7, 2020
  19. 16/21 t5318: update for SHA-256brian m. carlson, Feb 7, 2020
  20. 12/21 t5309: make test hash independentbrian m. carlson, Feb 7, 2020
  21. 09/21 t4211: add test cases for SHA-256brian m. carlson, Feb 7, 2020
  22. 08/21 t4211: move SHA-1-specific test cases into a directorybrian m. carlson, Feb 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.