git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 11/21] t5302: make hash size independent

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 7, 2020, 00:52 UTC
Message-ID
<20200207005254.1495851-12-sandals@crustytoothpaste.net>
In-Reply-To
<20200207005254.1495851-1-sandals@crustytoothpaste.net>

Compute the length of object IDs and pack offsets instead of hard-coding constants.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t5302-pack-index.sh | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh
index 91d51b35f9..ad07f2f7fc 100755
--- a/t/t5302-pack-index.sh
+++ b/t/t5302-pack-index.sh
@@ -6,9 +6,10 @@
 test_description='pack index with 64-bit offsets and object CRC'
 . ./test-lib.sh
 
-test_expect_success \
-    'setup' \
-    'rm -rf .git &&
+test_expect_success 'setup' '
+     test_oid_init &&
+     rawsz=$(test_oid rawsz) &&
+     rm -rf .git &&
      git init &&
      git config pack.threads 1 &&
      i=1 &&
@@ -32,7 +33,8 @@ test_expect_success \
 	 echo $tree &&
 	 git ls-tree $tree | sed -e "s/.* \\([0-9a-f]*\\)	.*/\\1/"
      } >obj-list &&
-     git update-ref HEAD $commit'
+     git update-ref HEAD $commit
+'
 
 test_expect_success \
     'pack-objects with index version 1' \
@@ -157,10 +159,11 @@ test_expect_success \
      offs_101=$(index_obj_offset 1.idx $sha1_101) &&
      nr_099=$(index_obj_nr 1.idx $sha1_099) &&
      chmod +w ".git/objects/pack/pack-${pack1}.pack" &&
+     recordsz=$((rawsz + 4)) &&
      dd of=".git/objects/pack/pack-${pack1}.pack" seek=$(($offs_101 + 1)) \
         if=".git/objects/pack/pack-${pack1}.idx" \
-        skip=$((4 + 256 * 4 + $nr_099 * 24)) \
-        bs=1 count=20 conv=notrunc &&
+        skip=$((4 + 256 * 4 + $nr_099 * recordsz)) \
+        bs=1 count=$rawsz conv=notrunc &&
      git cat-file blob $sha1_101 > file_101_foo1'
 
 test_expect_success \
@@ -200,8 +203,8 @@ test_expect_success \
      chmod +w ".git/objects/pack/pack-${pack1}.pack" &&
      dd of=".git/objects/pack/pack-${pack1}.pack" seek=$(($offs_101 + 1)) \
         if=".git/objects/pack/pack-${pack1}.idx" \
-        skip=$((8 + 256 * 4 + $nr_099 * 20)) \
-        bs=1 count=20 conv=notrunc &&
+        skip=$((8 + 256 * 4 + $nr_099 * rawsz)) \
+        bs=1 count=$rawsz conv=notrunc &&
      git cat-file blob $sha1_101 > file_101_foo2'
 
 test_expect_success \
@@ -226,7 +229,7 @@ test_expect_success \
      nr=$(index_obj_nr ".git/objects/pack/pack-${pack1}.idx" $obj) &&
      chmod +w ".git/objects/pack/pack-${pack1}.idx" &&
      printf xxxx | dd of=".git/objects/pack/pack-${pack1}.idx" conv=notrunc \
-        bs=1 count=4 seek=$((8 + 256 * 4 + $(wc -l <obj-list) * 20 + $nr * 4)) &&
+        bs=1 count=4 seek=$((8 + 256 * 4 + $(wc -l <obj-list) * rawsz + $nr * 4)) &&
      ( while read obj
        do git cat-file -p $obj >/dev/null || exit 1
        done <obj-list ) &&
Previous: brian m. carlsonNext: brian m. carlson
Message 10 of 22 in “SHA-256 test fixes, part 8”
  1. 00/21 SHA-256 test fixes, part 8brian m. carlson, Feb 7, 2020
  2. 01/21 t/lib-pack: support SHA-256brian m. carlson, Feb 7, 2020
  3. 02/21 t3206: make hash size independentbrian m. carlson, Feb 7, 2020
  4. 03/21 t3308: make test work with SHA-256brian m. carlson, Feb 7, 2020
  5. 07/21 t4013: make test hash independentbrian m. carlson, Feb 7, 2020
  6. 04/21 t3309: make test work with SHA-256brian m. carlson, Feb 7, 2020
  7. 06/21 t3311: make test work with SHA-256brian m. carlson, Feb 7, 2020
  8. 05/21 t3310: make test work with SHA-256brian m. carlson, Feb 7, 2020
  9. 10/21 t4060: make test work with SHA-256brian m. carlson, Feb 7, 2020
  10. 11/21 t5302: make hash size independentbrian m. carlson, Feb 7, 2020
  11. 15/21 t5515: make test hash independentbrian m. carlson, Feb 7, 2020
  12. 20/21 t6006: make hash size independentbrian m. carlson, Feb 7, 2020
  13. 18/21 t5703: make test work with SHA-256brian m. carlson, Feb 7, 2020
  14. 21/21 t6024: update for SHA-256brian m. carlson, Feb 7, 2020
  15. 14/21 t5321: make test hash independentbrian m. carlson, Feb 7, 2020
  16. 19/21 t6000: abstract away SHA-1-specific constantsbrian m. carlson, Feb 7, 2020
  17. 17/21 t5607: make hash size independentbrian m. carlson, Feb 7, 2020
  18. 13/21 t5313: make test hash independentbrian m. carlson, Feb 7, 2020
  19. 16/21 t5318: update for SHA-256brian m. carlson, Feb 7, 2020
  20. 12/21 t5309: make test hash independentbrian m. carlson, Feb 7, 2020
  21. 09/21 t4211: add test cases for SHA-256brian m. carlson, Feb 7, 2020
  22. 08/21 t4211: move SHA-1-specific test cases into a directorybrian m. carlson, Feb 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.