git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 20/21] t6006: make hash size independent

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 7, 2020, 00:52 UTC
Message-ID
<20200207005254.1495851-21-sandals@crustytoothpaste.net>
In-Reply-To
<20200207005254.1495851-1-sandals@crustytoothpaste.net>

Instead of hard-coding the length of an object ID when creating a tree, compute it for the hash in use using the translation tables.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t6006-rev-list-format.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh
index ebdc49c496..7e82e43a63 100755
--- a/t/t6006-rev-list-format.sh
+++ b/t/t6006-rev-list-format.sh
@@ -32,6 +32,7 @@ changed_iso88591=$(echo "$changed" | iconv -f utf-8 -t $test_encoding)
 truncate_count=20
 
 test_expect_success 'setup' '
+	test_oid_init &&
 	: >foo &&
 	git add foo &&
 	git config i18n.commitEncoding $test_encoding &&
@@ -463,9 +464,10 @@ test_expect_success '--abbrev' '
 '
 
 test_expect_success '%H is not affected by --abbrev-commit' '
+	expected=$(($(test_oid hexsz) + 1)) &&
 	git log -1 --format=%H --abbrev-commit --abbrev=20 HEAD >actual &&
 	len=$(wc -c <actual) &&
-	test $len = 41
+	test $len = $expected
 '
 
 test_expect_success '%h is not affected by --abbrev-commit' '
Previous: brian m. carlsonNext: brian m. carlson
Message 12 of 22 in “SHA-256 test fixes, part 8”
  1. 00/21 SHA-256 test fixes, part 8brian m. carlson, Feb 7, 2020
  2. 01/21 t/lib-pack: support SHA-256brian m. carlson, Feb 7, 2020
  3. 02/21 t3206: make hash size independentbrian m. carlson, Feb 7, 2020
  4. 03/21 t3308: make test work with SHA-256brian m. carlson, Feb 7, 2020
  5. 07/21 t4013: make test hash independentbrian m. carlson, Feb 7, 2020
  6. 04/21 t3309: make test work with SHA-256brian m. carlson, Feb 7, 2020
  7. 06/21 t3311: make test work with SHA-256brian m. carlson, Feb 7, 2020
  8. 05/21 t3310: make test work with SHA-256brian m. carlson, Feb 7, 2020
  9. 10/21 t4060: make test work with SHA-256brian m. carlson, Feb 7, 2020
  10. 11/21 t5302: make hash size independentbrian m. carlson, Feb 7, 2020
  11. 15/21 t5515: make test hash independentbrian m. carlson, Feb 7, 2020
  12. 20/21 t6006: make hash size independentbrian m. carlson, Feb 7, 2020
  13. 18/21 t5703: make test work with SHA-256brian m. carlson, Feb 7, 2020
  14. 21/21 t6024: update for SHA-256brian m. carlson, Feb 7, 2020
  15. 14/21 t5321: make test hash independentbrian m. carlson, Feb 7, 2020
  16. 19/21 t6000: abstract away SHA-1-specific constantsbrian m. carlson, Feb 7, 2020
  17. 17/21 t5607: make hash size independentbrian m. carlson, Feb 7, 2020
  18. 13/21 t5313: make test hash independentbrian m. carlson, Feb 7, 2020
  19. 16/21 t5318: update for SHA-256brian m. carlson, Feb 7, 2020
  20. 12/21 t5309: make test hash independentbrian m. carlson, Feb 7, 2020
  21. 09/21 t4211: add test cases for SHA-256brian m. carlson, Feb 7, 2020
  22. 08/21 t4211: move SHA-1-specific test cases into a directorybrian m. carlson, Feb 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.