Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Sep 4, 2019, 22:35 UTC
Message-ID: <20190904223508.lmima7iv4pbbhg3z@yadavpratyush.com>
In-Reply-To: <CAKPyHN39AXJBtuDepb-TgGSGrvqs4a5+yp74L5im3Svmw5S8aA@mail.gmail.com>

On 04/09/19 09:39PM, Bert Wesarg wrote:

> On Tue, Sep 3, 2019 at 7:15 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
> >
> > On 02/09/19 09:13PM, Bert Wesarg wrote:

[snip]

Show 18 quoted lines

> >
> > One more observation:
> >
> > If I write a particularly long line (and consequently the scrollbar
> > becomes active), and then hit Ctrl+A to select all text, and then
> > backspace to delete it all, the scrollbar does not get updated. It still
> > shows the old position where is is "scrolled" halfway through. As soon
> > as I type in any other character, it takes the correct state, and
> > becomes disabled.
> >
> > The vertical scrollbar behaves correctly in this scenario, and does take
> > the correct state and position as soon as I delete all text, so I
> > suspect it should be a small fix. Maybe a missed option or something
> > like that?
> 
> While I can reproduce this, I don't figured out what is wrong here. I
> tried a minimal example and this also fails. The yScrollCommand is
> issued, but the xScrollCommand not. I have tcl/tk 8.6.8 on Linux.

Well, I don't think this is a big enough problem to block this patch, but still something that should ideally be fixed.

I have a really busy week/weekend coming up, so I won't really be able to devote much time to this. I'll see if I can figure something out after that. I'll wait for some comments on your patches, and then get around to reading them myself when I get some more time. Thanks.

-- 
Regards,
Pratyush Yadav