Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Sep 2, 2019, 18:12 UTC
Message-ID: <20190902181213.7jqvoyctdm26g34z@yadavpratyush.com>
In-Reply-To: <CAGr--=+CEX-STDgT_ZwaA=n9UHSrsgcWnxCMY=9tGDA=9XLkew@mail.gmail.com>

On 02/09/19 07:04PM, Birger Skogeng Pedersen wrote:

Show 23 quoted lines

> Hi Bert,
> 
> 
> Thanks for picking this up.
> I just gave your patch a go, and I think there are a couple of issues.
> 
> 
> Applying the patch yields:
> 
> $ git apply patch1.patch
> patch1.patch:18: indent with spaces.
>        -yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set} \
> patch1.patch:19: indent with spaces.
>        -xscrollcommand {.vpane.lower.commarea.buffer.sbx set}
> patch1.patch:21: indent with spaces.
>        -orient vertical \
> patch1.patch:24: indent with spaces.
>        -orient horizontal \
> patch1.patch:25: indent with spaces.
>        -command [list $ui_comm xview]
> warning: git-gui.sh has type 100644, expected 100755
> error: patch failed: git-gui.sh:3363
> error: git-gui.sh: patch does not apply

 
It applied fine for me. I got the patch from Bert's GitHub since he said 
he is "unable to send patches per mail". You can run

  wget https://github.com/bertwesarg/git-gui/commit/0bfa0645127c8242a260f1dfe45d7d4c310fa868.patch

to get the .patch file, and then apply that. Maybe his email client messed up somewhere, and that's why your patch has whitespace problems.

Show 5 quoted lines

> Replacing the spaces with tabs before applying, I notice the
> horisontal scrollbar appears to be "outside" of the text input area.
> And it doesn't follow the height of the commit message text input
> area.
> Here's a screenshot: https://i.imgur.com/721axUX.png

 
Hmm, it looks fine for me. Which platform are you using? I am running it 
on Linux. Screenshot: https://imgur.com/sNp5Ktq

-- 
Regards,
Pratyush Yadav