Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Sep 4, 2019, 14:04 UTC
Message-ID: <20190904140437.xcosp24kpo5fiufa@yadavpratyush.com>
In-Reply-To: <CAGr--=+UA04F8JtpN3b8SahYtVkYgR45j_xeb3759DrtQOY6rg@mail.gmail.com>

On 04/09/19 07:42AM, Birger Skogeng Pedersen wrote:

Show 13 quoted lines

> Hi Pratyush,
> 
> 
> Just wanted to chime in on this one:
> 
> On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
> > On second thought, wouldn't it make more sense to expand the commit
> > message buffer instead? The point of resizing that pane is to see more
> > of the commit message. So it makes more sense to make the commit message
> > buffer take up all the vertical space, rather than making the scrollbar
> > move.
> 
> I also think it makes sense to expand the commit message buffer. And

Yes, it was actually a bug. Bert fixed it in his re-roll.

> how about automatic word wrapping? Should the user really have to care
> about the 72 character limit, while typing the commit message? I'm not
> sure what solution would be best.

Yes, that would be a neat feature. Tcl/Tk's text boxes have a "word wrap" feature [0], but I'm not sure if that's a soft-wrap or a hard-wrap. We can try experimenting with those to see how well it works. It would also be a good idea to have an option to disable the word wrap. Maybe do that by setting the "Commit message text width" to 0.

[0] https://www.tcl.tk/man/tcl8.4/TkCmd/text.htm#M16

-- 
Regards,
Pratyush Yadav