Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Sep 3, 2019, 17:15 UTC
Message-ID: <20190903171511.cd6vwn4kz7bdpose@yadavpratyush.com>
In-Reply-To: <CAKPyHN3=QY4+XNhQPq09_PALFwfR5bWBs7q6m6LkfFoW-xeCug@mail.gmail.com>

On 02/09/19 09:13PM, Bert Wesarg wrote:

> On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> >

[snip]

Show 12 quoted lines

> > > On second thought, wouldn't it make more sense to expand the 
> > > commit
> > > message buffer instead? The point of resizing that pane is to see more
> > > of the commit message. So it makes more sense to make the commit message
> > > buffer take up all the vertical space, rather than making the scrollbar
> > > move.
> >
> > it is, I just broke that ;-)
> 
> is fixed in GitHub:
> 
>     wget https://github.com/bertwesarg/git-gui/commit/56163547604f44688e208393f8941efaf5247d40.patch

I tried the patch out. Works fine on Linux. Thanks.

There is a minor typo in your commit message.

> Sugestted-by: Birger Skogeng Pedersen <birger.sp@gmail.com>

s/Sugestted/Suggested/

> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>

One more observation:

If I write a particularly long line (and consequently the scrollbar becomes active), and then hit Ctrl+A to select all text, and then backspace to delete it all, the scrollbar does not get updated. It still shows the old position where is is "scrolled" halfway through. As soon as I type in any other character, it takes the correct state, and becomes disabled.

The vertical scrollbar behaves correctly in this scenario, and does take the correct state and position as soon as I delete all text, so I suspect it should be a small fix. Maybe a missed option or something like that?

-- 
Regards,
Pratyush Yadav