git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] read-cache: write all indexes with the same permissions

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Nov 17, 2018, 12:38 UTC
Message-ID
<20181117123854.GQ30222@szeder.dev>
In-Reply-To
<CAP8UFD3sX4YPmyXtxbcL3-TZEyd_fq7MuSZkYeNGvqswuF4Ncw@mail.gmail.com>
On Sat, Nov 17, 2018 at 07:52:30AM +0100, Christian Couder wrote:
Show 11 quoted lines
> On Fri, Nov 16, 2018 at 8:20 PM Duy Nguyen <pclouds@gmail.com> wrote:
> >
> > On Fri, Nov 16, 2018 at 8:07 PM SZEDER Gábor <szeder.dev@gmail.com> wrote:
> >
> > > With the default 20% threshold a new shared index is written rather
> > > frequently with our usual small test-repos:
> >
> > Side note. Split index is definitely not meant for small repos.
> 
> I very much agree with that. It makes sense to use them only for big
> repos and big repos usually don't pass a 20% threshold very often.

But our test suite does use very small repositories, so perhaps we have been already testing what Ævar wanted to test? (Though I didn't quite understood what that was; and we likely don't do so explicitly, but only by chance with GIT_TEST_SPLIT_INDEX=1.)

Show 6 quoted lines
> > But
> > maybe we should have a lower limit (in terms of absolute number of
> > entries) that prevent splitting. This splitting seems excessive.
> 
> I would agree if split index was the default mode or if our goal was
> to eventually make it the default mode.

Same here. If you don't need split index, i.e. don't have huge repos, then don't enable it in the first place. And if it is enabled in a small repo, then the extra effort to write a new shared index is negligible, and the space wasted for those small files doesn't really matter (though arguably the output from a 'ls .git' would be surprising... which, at the same time, would be a good motivating factor to turn the feature off).

Previous: Christian Couder
Message 22 of 22 in “read-cache: use shared perms when writing shared index”
  1. 1/3 read-cache: use shared perms when writing shared indexChristian Couder, Jun 22, 2017
  2. 2/3 t1301: move movebits() to test-lib-functions.shChristian Couder, Jun 22, 2017
  3. Junio C HamanoJun 22, 2017
  4. Ramsay JonesJun 22, 2017
  5. Junio C HamanoJun 23, 2017
  6. Christian CouderJun 23, 2017
  7. 3/3 t1700: make sure split-index respects core.sharedrepositoryChristian Couder, Jun 22, 2017
  8. Junio C HamanoJun 22, 2017
  9. Christian CouderJun 22, 2017
  10. Junio C HamanoJun 22, 2017
  11. Christian CouderJun 22, 2017
  12. Junio C HamanoJun 22, 2017
  13. Christian CouderJun 23, 2017
  14. Ævar Arnfjörð BjarmasonNov 13, 2018
  15. read-cache: write all indexes with the same permissionsÆvar Arnfjörð Bjarmason, Nov 13, 2018
  16. Duy NguyenNov 13, 2018
  17. Ævar Arnfjörð BjarmasonNov 13, 2018
  18. Christian CouderNov 16, 2018
  19. SZEDER GáborNov 16, 2018
  20. Duy NguyenNov 16, 2018
  21. Christian CouderNov 17, 2018
  22. SZEDER GáborNov 17, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.