git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] coccicheck: process every source file at once

From
Jeff King <peff@peff.net>
Date
Oct 2, 2018, 21:08 UTC
Message-ID
<20181002210821.GA27904@sigill.intra.peff.net>
In-Reply-To
<CA+P7+xqxov6-+t6ixuVxUvi=yfjDuxsa8poGL0TrUrWoj3NUNA@mail.gmail.com>
On Tue, Oct 02, 2018 at 01:58:10PM -0700, Jacob Keller wrote:
Show 20 quoted lines
> On Tue, Oct 2, 2018 at 1:31 PM Jeff King <peff@peff.net> wrote:
> > Actually, I guess we do not need to save $? at all, since we have only a
> > single process to care about. So even simpler:
> >
> >   spatch ... 2>$@+ 2>$@.log ||
> >   {
> >         cat $@.log
> >         exit 1
> >   }
> >   # if we get here, we were successful
> >   mv $@+ $@ ;# etc
> >
> > would work. That's missing all the Makefile=required backslashes and
> > semicolons, of course. ;)
> >
> 
> I opted to drop to just save the return, immediately after calling.
> It's a bit less code change, and I think the result is as clear as the
> above would be. This way we do drop the subshell, not that it matters
> much in the end...

Yeah. To be clear, I'm fine with any of the versions discussed in this thread. Thanks for working on this!

-Peff
Previous: Jacob KellerNext: SZEDER Gábor
Message 6 of 11 in “coccicheck: process every source file at once”
  1. coccicheck: process every source file at onceJacob Keller, Oct 2, 2018
  2. Jeff KingOct 2, 2018
  3. Jacob KellerOct 2, 2018
  4. Jeff KingOct 2, 2018
  5. Jacob KellerOct 2, 2018
  6. Jeff KingOct 2, 2018
  7. SZEDER GáborOct 3, 2018
  8. SZEDER GáborOct 3, 2018
  9. Jacob KellerOct 3, 2018
  10. Stefan BellerOct 3, 2018
  11. Jacob KellerOct 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.