From: Jeff King <peff@peff.net>
Date: Tue, 02 Oct 2018 21:08:21 GMT
Subject: Re: [PATCH] coccicheck: process every source file at once
Message-ID: <20181002210821.GA27904@sigill.intra.peff.net>
In-Reply-To: <CA+P7+xqxov6-+t6ixuVxUvi=yfjDuxsa8poGL0TrUrWoj3NUNA@mail.gmail.com>

On Tue, Oct 02, 2018 at 01:58:10PM -0700, Jacob Keller wrote:

> On Tue, Oct 2, 2018 at 1:31 PM Jeff King <peff@peff.net> wrote:
> > Actually, I guess we do not need to save $? at all, since we have only a
> > single process to care about. So even simpler:
> >
> >   spatch ... 2>$@+ 2>$@.log ||
> >   {
> >         cat $@.log
> >         exit 1
> >   }
> >   # if we get here, we were successful
> >   mv $@+ $@ ;# etc
> >
> > would work. That's missing all the Makefile=required backslashes and
> > semicolons, of course. ;)
> >
> 
> I opted to drop to just save the return, immediately after calling.
> It's a bit less code change, and I think the result is as clear as the
> above would be. This way we do drop the subshell, not that it matters
> much in the end...

Yeah. To be clear, I'm fine with any of the versions discussed in this
thread. Thanks for working on this!

-Peff