Re: [PATCH] coccicheck: process every source file at once

From: Stefan Beller <sbeller@google.com>
Date: Oct 3, 2018, 17:54 UTC
Message-ID: <CAGZ79kZKb_t5ALF6KPtKt05gt1jv5gZL_rrdmeO5vNAb7ed8bQ@mail.gmail.com>
In-Reply-To: <CA+P7+xpB5Pqj7Kp5HiUDqtNMiX8+kGt5QfwLaZ+ROY9jj+Xnrg@mail.gmail.com>

On Wed, Oct 3, 2018 at 8:52 AM Jacob Keller <jacob.keller@gmail.com> wrote:

Show 17 quoted lines

>
> On Wed, Oct 3, 2018 at 8:05 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
> > In fact, it works finer than ever, because running 1.0.0 with this
> > patch on Travis CI notices a possible memmove() -> MOVE_ARRAY()
> > conversion:
> >
> >   https://travis-ci.org/szeder/git/jobs/436542684#L576
> >
> > Surprisingly, running 1.0.0 without this patch, or running 1.0.4
> > locally either with or without this patch doesn't notice that
> > memmove() call.  Presumably that's why Jonathan could kind-of "revert"
> > my conversion from f919ffebed (Use MOVE_ARRAY, 2018-01-22) in his
> > 6a1a79fd14 (object: move grafts to object parser, 2018-05-15) without
> > anyone noticing.
> >
>
> That seems very odd...

That looks like a bad rebase on my side as I was carrying that patch for a while as the development of object store series took some time.

And I agree we should re-introduce the MOVE_ARRAY there.