Re: [PATCH] coccicheck: process every source file at once

From: Jacob Keller <jacob.keller@gmail.com>
Date: Oct 2, 2018, 20:58 UTC
Message-ID: <CA+P7+xqxov6-+t6ixuVxUvi=yfjDuxsa8poGL0TrUrWoj3NUNA@mail.gmail.com>
In-Reply-To: <20181002203124.GC2014@sigill.intra.peff.net>

On Tue, Oct 2, 2018 at 1:31 PM Jeff King <peff@peff.net> wrote:

Show 14 quoted lines

> Actually, I guess we do not need to save $? at all, since we have only a
> single process to care about. So even simpler:
>
>   spatch ... 2>$@+ 2>$@.log ||
>   {
>         cat $@.log
>         exit 1
>   }
>   # if we get here, we were successful
>   mv $@+ $@ ;# etc
>
> would work. That's missing all the Makefile=required backslashes and
> semicolons, of course. ;)
>

I opted to drop to just save the return, immediately after calling. It's a bit less code change, and I think the result is as clear as the above would be. This way we do drop the subshell, not that it matters much in the end...

Thanks, Jake

> -Peff