git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test_must_be_empty: simplify file existence check

From
Jeff King <peff@peff.net>
Date
Mar 26, 2018, 12:48 UTC
Message-ID
<20180326124847.GA21993@sigill.intra.peff.net>
In-Reply-To
<20180326115815.10180-1-szeder.dev@gmail.com>
On Mon, Mar 26, 2018 at 01:58:15PM +0200, SZEDER Gábor wrote:
Show 5 quoted lines
> Commit ea3c87d0b7 (test_must_be_empty: make sure the file exists, not
> just empty, 2018-02-27) basically duplicated the 'test_path_is_file'
> helper function in 'test_must_be_empty'.
> 
> Just call 'test_path_is_file' to avoid this code duplication.
This looks like an improvement to me.

I think you meant to reference 11395a3b4b16d9fc637ca2e41a6892ea2e6289ce, though (I don't have ea3c87d0b7 at all).

-Peff
Previous: SZEDER GáborNext: SZEDER Gábor
Message 2 of 6 in “test_must_be_empty: simplify file existence check”
  1. test_must_be_empty: simplify file existence checkSZEDER Gábor, Mar 26, 2018
  2. Jeff KingMar 26, 2018
  3. SZEDER GáborMar 26, 2018
  4. test_must_be_empty: simplify file existence checkSZEDER Gábor, Mar 26, 2018
  5. Junio C HamanoMar 28, 2018
  6. Junio C HamanoMar 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.