Re: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.

From: Jeff King <peff@peff.net>
Date: Mar 1, 2018, 07:36 UTC
Message-ID: <20180301073629.GC31079@sigill.intra.peff.net>
In-Reply-To: <CANgJU+VYkmUhJT=CHQ4HTqoV4gWhr9P4-65BfrY-RWgwJJhEUA@mail.gmail.com>

On Wed, Feb 28, 2018 at 05:51:14PM +0100, demerphq wrote:

Show 12 quoted lines

> I would look into putting it into a module and then using the PERL5OPT
> environment var to have it loaded automagically in any of your perl
> scripts.
> 
> For instance if you put that code into a module called Git/DieTrap.pm
> 
> then you could do:
> 
> PERL5OPT=-MGit::DieTrap
> 
> In your test setup code assuming you have some. Then you don't need to
> change any of your scripts just the test runner framework.

That's a clever trick.

It's not clear to me though if we just want to tweak the programs run in the test scripts in order to get test_must_fail to stop complaining, or if we consider the unusual exit codes from our perl-based Git programs to be an error that should be fixed for real use, too.

-Peff