Re: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Feb 28, 2018, 23:16 UTC
- Message-ID
- <20180228231638.GG251290@aiede.svl.corp.google.com>
- In-Reply-To
- <007001d3b0df$e8b9c280$ba2d4780$@nexbridge.com>
Randall S. Becker wrote:
Show 6 quoted lines
> The original thread below has details of what the original issue was and > why. It hit three tests specifically on this platform where die was invoked > (at least on one of them). Perl was invoked under the covers and the > completion code of 169 propagated back through git to the test framework. > https://public-inbox.org/git/499fb29f-ca34-8d28-256d-896107c29a3e@kdbg.org/T > /#m0b30f0857feae2044f38e04dc6b8565b68b7d52b
That is:
test_must_fail git send-email --dump-aliases --to=janice@example.com -1 refs/heads/accounting
Which matches the case described elsewhere in this thread. It's git-send-email.perl. test_must_fail is doing its job correctly by diagnosing a real bug in git-send-email.perl, which we're grateful for you having discovered. :)
Thanks, Jonathan