RE: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.

From: Randall S. Becker <rsbecker@nexbridge.com>
Date: Feb 28, 2018, 20:04 UTC
Message-ID: <006901d3b0cf$4a3f7d30$debe7790$@nexbridge.com>
In-Reply-To: <20180228185152.GE251290@aiede.svl.corp.google.com>

On February 28, 2018 1:52 PM, Jonathan Nieder wrote:

Show 14 quoted lines

> Randall S. Becker wrote:
> > On February 28, 2018 12:44 PM, Jonathan Nieder wrote:
> >> Randall S. Becker wrote:
> 
> >>> The problem is actually in git code in its test suite that uses perl
> >>> inline, not in my test code itself.
> [...]
> >> Can you elaborate with an example?  My understanding was that
> >> test_must_fail is only for running git.
> [...]
> > Have a look at a recent t1404 as a sample. Line 615 is the one causing
> > the platform grief, because it triggers a 'die'. However, the
> > particular test case #54, had no difference on platform with
> > test_must_fail or !, which has the same underlying EBADF completion

after

Show 5 quoted lines

> digging and digging.
> 
> Sorry to be dense: what I see on that line is
> 
> 	test_must_fail git update-ref -d $prefix/foo >out 2>err &&

My bad, I think. I'm going to go looking through my notes and get back on which line in the test was the issue. I assumed from your response that it might have been the test_must_fail, which is throughout the git test suite. Obviously it isn't the line failing in this case. Stay tuned.