RE: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.
- From
Randall S. Becker <rsbecker@nexbridge.com>
- Date
- Feb 28, 2018, 22:02 UTC
- Message-ID
- <007001d3b0df$e8b9c280$ba2d4780$@nexbridge.com>
- In-Reply-To
- <006901d3b0cf$4a3f7d30$debe7790$@nexbridge.com>
On February 28, 2018 3:04 PM, Jonathan Nieder wrote:
Show 25 quoted lines
> On February 28, 2018 1:52 PM, Jonathan Nieder wrote: > > Randall S. Becker wrote: > > > On February 28, 2018 12:44 PM, Jonathan Nieder wrote: > > >> Randall S. Becker wrote: > > > > >>> The problem is actually in git code in its test suite that uses > > >>> perl inline, not in my test code itself. > > [...] > > >> Can you elaborate with an example? My understanding was that > > >> test_must_fail is only for running git. > > [...] > > > Have a look at a recent t1404 as a sample. Line 615 is the one > > > causing the platform grief, because it triggers a 'die'. However, > > > the particular test case #54, had no difference on platform with > > > test_must_fail or !, which has the same underlying EBADF completion > after > > digging and digging. > > > > Sorry to be dense: what I see on that line is > > > > test_must_fail git update-ref -d $prefix/foo >out 2>err && > > My bad, I think. I'm going to go looking through my notes and get back on > which line in the test was the issue. I assumed from your response that it > might have been the test_must_fail, which is throughout the git test
suite.
> Obviously it isn't the line failing in this case. Stay tuned.
The original thread below has details of what the original issue was and why. It hit three tests specifically on this platform where die was invoked (at least on one of them). Perl was invoked under the covers and the completion code of 169 propagated back through git to the test framework. https://public-inbox.org/git/499fb29f-ca34-8d28-256d-896107c29a3e@kdbg.org/T /#m0b30f0857feae2044f38e04dc6b8565b68b7d52b
While removing test_must_fail is laudable, it won't seemingly solve the underlying cause that I am trying to work through, which is inserting the $SIGdie reporting 169 on platform and inserting:
SIG{__DIE__} = sub {
CORE::die @_ if $^S || !defined($^S);
print STDERR "fatal: @_";
exit 128;
};I just don't know the framework well enough (or perl for that matter) to know the exact spot to place this so that it would work properly and be acceptable to the committers (you know who you are :-) ).
I hope that provides info on what is going on and why I am motivated to fix this by (nearly) whatever means necessary.
Cheers, Randall
-- Brief whoami: NonStop developer since approximately 211288444200000000 UNIX developer since approximately 421664400 -- In my real life, I talk too much.