git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 35/37] tempfile: rename 'template' variables

From
BWBrandon Williams <bmwill@google.com>
Date
Jan 29, 2018, 22:37 UTC
Message-ID
<20180129223728.30569-36-bmwill@google.com>
In-Reply-To
<20180129223728.30569-1-bmwill@google.com>

Rename C++ keyword in order to bring the codebase closer to being able to be compiled with a C++ compiler.

Signed-off-by: Brandon Williams <bmwill@google.com>
---
 tempfile.c | 12 ++++++------
 tempfile.h | 34 +++++++++++++++++-----------------
 2 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/tempfile.c b/tempfile.c
index 5fdafdd2d..139ecd97f 100644
--- a/tempfile.c
+++ b/tempfile.c
@@ -165,11 +165,11 @@ struct tempfile *register_tempfile(const char *path)
 	return tempfile;
 }
 
-struct tempfile *mks_tempfile_sm(const char *template, int suffixlen, int mode)
+struct tempfile *mks_tempfile_sm(const char *filename_template, int suffixlen, int mode)
 {
 	struct tempfile *tempfile = new_tempfile();
 
-	strbuf_add_absolute_path(&tempfile->filename, template);
+	strbuf_add_absolute_path(&tempfile->filename, filename_template);
 	tempfile->fd = git_mkstemps_mode(tempfile->filename.buf, suffixlen, mode);
 	if (tempfile->fd < 0) {
 		deactivate_tempfile(tempfile);
@@ -179,7 +179,7 @@ struct tempfile *mks_tempfile_sm(const char *template, int suffixlen, int mode)
 	return tempfile;
 }
 
-struct tempfile *mks_tempfile_tsm(const char *template, int suffixlen, int mode)
+struct tempfile *mks_tempfile_tsm(const char *filename_template, int suffixlen, int mode)
 {
 	struct tempfile *tempfile = new_tempfile();
 	const char *tmpdir;
@@ -188,7 +188,7 @@ struct tempfile *mks_tempfile_tsm(const char *template, int suffixlen, int mode)
 	if (!tmpdir)
 		tmpdir = "/tmp";
 
-	strbuf_addf(&tempfile->filename, "%s/%s", tmpdir, template);
+	strbuf_addf(&tempfile->filename, "%s/%s", tmpdir, filename_template);
 	tempfile->fd = git_mkstemps_mode(tempfile->filename.buf, suffixlen, mode);
 	if (tempfile->fd < 0) {
 		deactivate_tempfile(tempfile);
@@ -198,12 +198,12 @@ struct tempfile *mks_tempfile_tsm(const char *template, int suffixlen, int mode)
 	return tempfile;
 }
 
-struct tempfile *xmks_tempfile_m(const char *template, int mode)
+struct tempfile *xmks_tempfile_m(const char *filename_template, int mode)
 {
 	struct tempfile *tempfile;
 	struct strbuf full_template = STRBUF_INIT;
 
-	strbuf_add_absolute_path(&full_template, template);
+	strbuf_add_absolute_path(&full_template, filename_template);
 	tempfile = mks_tempfile_m(full_template.buf, mode);
 	if (!tempfile)
 		die_errno("Unable to create temporary file '%s'",
diff --git a/tempfile.h b/tempfile.h
index 450908b2e..8959c5f1b 100644
--- a/tempfile.h
+++ b/tempfile.h
@@ -135,58 +135,58 @@ extern struct tempfile *register_tempfile(const char *path);
  */
 
 /* See "mks_tempfile functions" above. */
-extern struct tempfile *mks_tempfile_sm(const char *template,
+extern struct tempfile *mks_tempfile_sm(const char *filename_template,
 					int suffixlen, int mode);
 
 /* See "mks_tempfile functions" above. */
-static inline struct tempfile *mks_tempfile_s(const char *template,
+static inline struct tempfile *mks_tempfile_s(const char *filename_template,
 					      int suffixlen)
 {
-	return mks_tempfile_sm(template, suffixlen, 0600);
+	return mks_tempfile_sm(filename_template, suffixlen, 0600);
 }
 
 /* See "mks_tempfile functions" above. */
-static inline struct tempfile *mks_tempfile_m(const char *template, int mode)
+static inline struct tempfile *mks_tempfile_m(const char *filename_template, int mode)
 {
-	return mks_tempfile_sm(template, 0, mode);
+	return mks_tempfile_sm(filename_template, 0, mode);
 }
 
 /* See "mks_tempfile functions" above. */
-static inline struct tempfile *mks_tempfile(const char *template)
+static inline struct tempfile *mks_tempfile(const char *filename_template)
 {
-	return mks_tempfile_sm(template, 0, 0600);
+	return mks_tempfile_sm(filename_template, 0, 0600);
 }
 
 /* See "mks_tempfile functions" above. */
-extern struct tempfile *mks_tempfile_tsm(const char *template,
+extern struct tempfile *mks_tempfile_tsm(const char *filename_template,
 					 int suffixlen, int mode);
 
 /* See "mks_tempfile functions" above. */
-static inline struct tempfile *mks_tempfile_ts(const char *template,
+static inline struct tempfile *mks_tempfile_ts(const char *filename_template,
 					       int suffixlen)
 {
-	return mks_tempfile_tsm(template, suffixlen, 0600);
+	return mks_tempfile_tsm(filename_template, suffixlen, 0600);
 }
 
 /* See "mks_tempfile functions" above. */
-static inline struct tempfile *mks_tempfile_tm(const char *template, int mode)
+static inline struct tempfile *mks_tempfile_tm(const char *filename_template, int mode)
 {
-	return mks_tempfile_tsm(template, 0, mode);
+	return mks_tempfile_tsm(filename_template, 0, mode);
 }
 
 /* See "mks_tempfile functions" above. */
-static inline struct tempfile *mks_tempfile_t(const char *template)
+static inline struct tempfile *mks_tempfile_t(const char *filename_template)
 {
-	return mks_tempfile_tsm(template, 0, 0600);
+	return mks_tempfile_tsm(filename_template, 0, 0600);
 }
 
 /* See "mks_tempfile functions" above. */
-extern struct tempfile *xmks_tempfile_m(const char *template, int mode);
+extern struct tempfile *xmks_tempfile_m(const char *filename_template, int mode);
 
 /* See "mks_tempfile functions" above. */
-static inline struct tempfile *xmks_tempfile(const char *template)
+static inline struct tempfile *xmks_tempfile(const char *filename_template)
 {
-	return xmks_tempfile_m(template, 0600);
+	return xmks_tempfile_m(filename_template, 0600);
 }
 
 /*
-- 
2.16.0.rc1.238.g530d649a79-goog
Previous: Brandon WilliamsNext: Brandon Williams
Message 24 of 89 in “removal of some c++ keywords”
  1. 00/37 removal of some c++ keywordsBrandon Williams, Jan 29, 2018
  2. 01/37 object_info: change member name from 'typename' to 'type_name'Brandon Williams, Jan 29, 2018
  3. 02/37 object: rename function 'typename' to 'type_name'Brandon Williams, Jan 29, 2018
  4. 03/37 blame: rename 'this' variablesBrandon Williams, Jan 29, 2018
  5. 04/37 pack-objects: rename 'this' variablesBrandon Williams, Jan 29, 2018
  6. 05/37 rev-parse: rename 'this' variableBrandon Williams, Jan 29, 2018
  7. 06/37 diff: rename 'this' variablesBrandon Williams, Jan 29, 2018
  8. 08/37 apply: rename 'new' variablesBrandon Williams, Jan 29, 2018
  9. 07/37 apply: rename 'try' variablesBrandon Williams, Jan 29, 2018
  10. 09/37 checkout: rename 'new' variablesBrandon Williams, Jan 29, 2018
  11. 14/37 combine-diff: rename 'new' variablesBrandon Williams, Jan 29, 2018
  12. 17/37 diff: rename 'new' variablesBrandon Williams, Jan 29, 2018
  13. 18/37 diffcore-delta: rename 'new' variablesBrandon Williams, Jan 29, 2018
  14. 19/37 entry: rename 'new' variablesBrandon Williams, Jan 29, 2018
  15. 23/37 read-cache: rename 'new' variablesBrandon Williams, Jan 29, 2018
  16. 24/37 ref-filter: rename 'new' variablesBrandon Williams, Jan 29, 2018
  17. 26/37 split-index: rename 'new' variablesBrandon Williams, Jan 29, 2018
  18. 25/37 remote: rename 'new' variablesBrandon Williams, Jan 29, 2018
  19. 22/37 line-log: rename 'new' variablesBrandon Williams, Jan 29, 2018
  20. 30/37 init-db: rename 'template' variablesBrandon Williams, Jan 29, 2018
  21. 31/37 environment: rename 'template' variablesBrandon Williams, Jan 29, 2018
  22. 32/37 diff: rename 'template' variablesBrandon Williams, Jan 29, 2018
  23. 34/37 wrapper: rename 'template' variablesBrandon Williams, Jan 29, 2018
  24. 35/37 tempfile: rename 'template' variablesBrandon Williams, Jan 29, 2018
  25. 36/37 trailer: rename 'template' variablesBrandon Williams, Jan 29, 2018
  26. 37/37 replace: rename 'new' variablesBrandon Williams, Jan 29, 2018
  27. Stefan BellerJan 30, 2018
  28. Junio C HamanoJan 30, 2018
  29. 33/37 environment: rename 'namespace' variablesBrandon Williams, Jan 29, 2018
  30. 27/37 submodule: rename 'new' variablesBrandon Williams, Jan 29, 2018
  31. 28/37 trailer: rename 'new' variablesBrandon Williams, Jan 29, 2018
  32. 29/37 unpack-trees: rename 'new' variablesBrandon Williams, Jan 29, 2018
  33. 21/37 imap-send: rename 'new' variablesBrandon Williams, Jan 29, 2018
  34. 20/37 http: rename 'new' variablesBrandon Williams, Jan 29, 2018
  35. 15/37 commit: rename 'new' variablesBrandon Williams, Jan 29, 2018
  36. 16/37 diff-lib: rename 'new' variableBrandon Williams, Jan 29, 2018
  37. 10/37 help: rename 'new' variablesBrandon Williams, Jan 29, 2018
  38. 13/37 remote: rename 'new' variablesBrandon Williams, Jan 29, 2018
  39. 11/37 pack-redundant: rename 'new' variablesBrandon Williams, Jan 29, 2018
  40. 12/37 reflog: rename 'new' variablesBrandon Williams, Jan 29, 2018
  41. Duy NguyenJan 30, 2018
  42. Junio C HamanoJan 30, 2018
  43. Stefan BellerJan 30, 2018
  44. Duy NguyenJan 31, 2018
  45. Stefan BellerJan 31, 2018
  46. Duy NguyenJan 31, 2018
  47. Johannes SixtJan 30, 2018
  48. 00/37 removal of some c++ keywordsBrandon Williams, Feb 14, 2018
  49. 01/37 object_info: change member name from 'typename' to 'type_name'Brandon Williams, Feb 14, 2018
  50. 02/37 object: rename function 'typename' to 'type_name'Brandon Williams, Feb 14, 2018
  51. 04/37 pack-objects: rename 'this' variablesBrandon Williams, Feb 14, 2018
  52. 03/37 blame: rename 'this' variablesBrandon Williams, Feb 14, 2018
  53. 05/37 rev-parse: rename 'this' variableBrandon Williams, Feb 14, 2018
  54. 06/37 diff: rename 'this' variablesBrandon Williams, Feb 14, 2018
  55. Junio C HamanoFeb 14, 2018
  56. Brandon WilliamsFeb 14, 2018
  57. 09/37 checkout: rename 'new' variablesBrandon Williams, Feb 14, 2018
  58. 10/37 help: rename 'new' variablesBrandon Williams, Feb 14, 2018
  59. 11/37 pack-redundant: rename 'new' variablesBrandon Williams, Feb 14, 2018
  60. 12/37 reflog: rename 'new' variablesBrandon Williams, Feb 14, 2018
  61. 15/37 commit: rename 'new' variablesBrandon Williams, Feb 14, 2018
  62. 16/37 diff-lib: rename 'new' variableBrandon Williams, Feb 14, 2018
  63. 18/37 diffcore-delta: rename 'new' variablesBrandon Williams, Feb 14, 2018
  64. 19/37 entry: rename 'new' variablesBrandon Williams, Feb 14, 2018
  65. 20/37 http: rename 'new' variablesBrandon Williams, Feb 14, 2018
  66. 21/37 imap-send: rename 'new' variablesBrandon Williams, Feb 14, 2018
  67. 22/37 line-log: rename 'new' variablesBrandon Williams, Feb 14, 2018
  68. 23/37 read-cache: rename 'new' variablesBrandon Williams, Feb 14, 2018
  69. 24/37 ref-filter: rename 'new' variablesBrandon Williams, Feb 14, 2018
  70. 26/37 split-index: rename 'new' variablesBrandon Williams, Feb 14, 2018
  71. 25/37 remote: rename 'new' variablesBrandon Williams, Feb 14, 2018
  72. 28/37 trailer: rename 'new' variablesBrandon Williams, Feb 14, 2018
  73. 29/37 unpack-trees: rename 'new' variablesBrandon Williams, Feb 14, 2018
  74. 27/37 submodule: rename 'new' variablesBrandon Williams, Feb 14, 2018
  75. 30/37 init-db: rename 'template' variablesBrandon Williams, Feb 14, 2018
  76. 33/37 environment: rename 'namespace' variablesBrandon Williams, Feb 14, 2018
  77. 34/37 wrapper: rename 'template' variablesBrandon Williams, Feb 14, 2018
  78. 35/37 tempfile: rename 'template' variablesBrandon Williams, Feb 14, 2018
  79. 36/37 trailer: rename 'template' variablesBrandon Williams, Feb 14, 2018
  80. 37/37 replace: rename 'new' variablesBrandon Williams, Feb 14, 2018
  81. 31/37 environment: rename 'template' variablesBrandon Williams, Feb 14, 2018
  82. 32/37 diff: rename 'template' variablesBrandon Williams, Feb 14, 2018
  83. 17/37 diff: rename 'new' variablesBrandon Williams, Feb 14, 2018
  84. 07/37 apply: rename 'try' variablesBrandon Williams, Feb 14, 2018
  85. 14/37 combine-diff: rename 'new' variablesBrandon Williams, Feb 14, 2018
  86. 08/37 apply: rename 'new' variablesBrandon Williams, Feb 14, 2018
  87. Stefan BellerFeb 14, 2018
  88. 13/37 remote: rename 'new' variablesBrandon Williams, Feb 14, 2018
  89. Stefan BellerFeb 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.