git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/37] removal of some c++ keywords

From
BWBrandon Williams <bmwill@google.com>
Date
Jan 29, 2018, 22:36 UTC
Message-ID
<20180129223728.30569-1-bmwill@google.com>

A while back there was some discussion of getting our codebase into a state where we could use a c++ compiler if we wanted to (for various reason like leveraging c++ only analysis tools, etc.). Johannes Sixt had a very large patch that achieved this but it wasn't in a state where it could be upstreamed. I took that idea and did some removals of c++ keywords (new, template, try, this, etc) but broke it up into several (well maybe more than several) patches. I don't believe I've captured all of them in this series but this is at least moving a step closer to being able to compile using a c++ compiler.

I don't know if this is something the community still wants to move towards, but if this is something people are still interested in, and this series is wanted, then we can keep doing these sort of conversions in chunks slowly.

Brandon Williams (37):
  object_info: change member name from 'typename' to 'type_name'
  object: rename function 'typename' to 'type_name'
  blame: rename 'this' variables
  pack-objects: rename 'this' variables
  rev-parse: rename 'this' variable
  diff: rename 'this' variables
  apply: rename 'try' variables
  apply: rename 'new' variables
  checkout: rename 'new' variables
  help: rename 'new' variables
  pack-redundant: rename 'new' variables
  reflog: rename 'new' variables
  remote: rename 'new' variables
  combine-diff: rename 'new' variables
  commit: rename 'new' variables
  diff-lib: rename 'new' variable
  diff: rename 'new' variables
  diffcore-delta: rename 'new' variables
  entry: rename 'new' variables
  http: rename 'new' variables
  imap-send: rename 'new' variables
  line-log: rename 'new' variables
  read-cache: rename 'new' variables
  ref-filter: rename 'new' variables
  remote: rename 'new' variables
  split-index: rename 'new' variables
  submodule: rename 'new' variables
  trailer: rename 'new' variables
  unpack-trees: rename 'new' variables
  init-db: rename 'template' variables
  environment: rename 'template' variables
  diff: rename 'template' variables
  environment: rename 'namespace' variables
  wrapper: rename 'template' variables
  tempfile: rename 'template' variables
  trailer: rename 'template' variables
  replace: rename 'new' variables
 apply.c                                | 106 ++++++++++++-------------
 blame.c                                |  33 ++++----
 builtin/cat-file.c                     |   4 +-
 builtin/checkout.c                     | 138 ++++++++++++++++-----------------
 builtin/diff-tree.c                    |   2 +-
 builtin/fast-export.c                  |   8 +-
 builtin/fsck.c                         |   4 +-
 builtin/grep.c                         |   2 +-
 builtin/help.c                         |  10 +--
 builtin/index-pack.c                   |  12 +--
 builtin/init-db.c                      |  30 +++----
 builtin/merge.c                        |   2 +-
 builtin/mktree.c                       |   4 +-
 builtin/pack-objects.c                 |   8 +-
 builtin/pack-redundant.c               |  48 ++++++------
 builtin/prune.c                        |   2 +-
 builtin/reflog.c                       |   8 +-
 builtin/remote.c                       |  44 +++++------
 builtin/replace.c                      |  28 +++----
 builtin/rev-parse.c                    |  34 ++++----
 builtin/tag.c                          |   2 +-
 builtin/unpack-objects.c               |  10 +--
 builtin/verify-commit.c                |   2 +-
 bulk-checkin.c                         |   2 +-
 cache.h                                |   4 +-
 combine-diff.c                         |  12 +--
 commit.c                               |  20 ++---
 contrib/examples/builtin-fetch--tool.c |   2 +-
 diff-lib.c                             |  20 ++---
 diff.c                                 |  38 ++++-----
 diffcore-delta.c                       |  16 ++--
 entry.c                                |  40 +++++-----
 environment.c                          |  24 +++---
 fast-import.c                          |  16 ++--
 fsck.c                                 |   2 +-
 git-compat-util.h                      |   4 +-
 http-push.c                            |   2 +-
 http.c                                 |  10 +--
 imap-send.c                            |  14 ++--
 line-log.c                             |  48 ++++++------
 log-tree.c                             |   2 +-
 object.c                               |   6 +-
 object.h                               |   2 +-
 pack-check.c                           |   2 +-
 packfile.c                             |   8 +-
 reachable.c                            |   2 +-
 read-cache.c                           |  36 ++++-----
 ref-filter.c                           |  20 ++---
 remote.c                               |  16 ++--
 sequencer.c                            |   2 +-
 sha1_file.c                            |  28 +++----
 sha1_name.c                            |   6 +-
 split-index.c                          |  10 +--
 split-index.h                          |   2 +-
 submodule.c                            |  16 ++--
 submodule.h                            |   2 +-
 tag.c                                  |   2 +-
 tempfile.c                             |  12 +--
 tempfile.h                             |  34 ++++----
 trailer.c                              |  44 +++++------
 unpack-trees.c                         |   6 +-
 walker.c                               |   4 +-
 wrapper.c                              |  40 +++++-----
 63 files changed, 559 insertions(+), 558 deletions(-)
-- 
2.16.0.rc1.238.g530d649a79-goog
Next: Brandon Williams
Message 1 of 89 in “removal of some c++ keywords”
  1. 00/37 removal of some c++ keywordsBrandon Williams, Jan 29, 2018
  2. 01/37 object_info: change member name from 'typename' to 'type_name'Brandon Williams, Jan 29, 2018
  3. 02/37 object: rename function 'typename' to 'type_name'Brandon Williams, Jan 29, 2018
  4. 03/37 blame: rename 'this' variablesBrandon Williams, Jan 29, 2018
  5. 04/37 pack-objects: rename 'this' variablesBrandon Williams, Jan 29, 2018
  6. 05/37 rev-parse: rename 'this' variableBrandon Williams, Jan 29, 2018
  7. 06/37 diff: rename 'this' variablesBrandon Williams, Jan 29, 2018
  8. 08/37 apply: rename 'new' variablesBrandon Williams, Jan 29, 2018
  9. 07/37 apply: rename 'try' variablesBrandon Williams, Jan 29, 2018
  10. 09/37 checkout: rename 'new' variablesBrandon Williams, Jan 29, 2018
  11. 14/37 combine-diff: rename 'new' variablesBrandon Williams, Jan 29, 2018
  12. 17/37 diff: rename 'new' variablesBrandon Williams, Jan 29, 2018
  13. 18/37 diffcore-delta: rename 'new' variablesBrandon Williams, Jan 29, 2018
  14. 19/37 entry: rename 'new' variablesBrandon Williams, Jan 29, 2018
  15. 23/37 read-cache: rename 'new' variablesBrandon Williams, Jan 29, 2018
  16. 24/37 ref-filter: rename 'new' variablesBrandon Williams, Jan 29, 2018
  17. 26/37 split-index: rename 'new' variablesBrandon Williams, Jan 29, 2018
  18. 25/37 remote: rename 'new' variablesBrandon Williams, Jan 29, 2018
  19. 22/37 line-log: rename 'new' variablesBrandon Williams, Jan 29, 2018
  20. 30/37 init-db: rename 'template' variablesBrandon Williams, Jan 29, 2018
  21. 31/37 environment: rename 'template' variablesBrandon Williams, Jan 29, 2018
  22. 32/37 diff: rename 'template' variablesBrandon Williams, Jan 29, 2018
  23. 34/37 wrapper: rename 'template' variablesBrandon Williams, Jan 29, 2018
  24. 35/37 tempfile: rename 'template' variablesBrandon Williams, Jan 29, 2018
  25. 36/37 trailer: rename 'template' variablesBrandon Williams, Jan 29, 2018
  26. 37/37 replace: rename 'new' variablesBrandon Williams, Jan 29, 2018
  27. Stefan BellerJan 30, 2018
  28. Junio C HamanoJan 30, 2018
  29. 33/37 environment: rename 'namespace' variablesBrandon Williams, Jan 29, 2018
  30. 27/37 submodule: rename 'new' variablesBrandon Williams, Jan 29, 2018
  31. 28/37 trailer: rename 'new' variablesBrandon Williams, Jan 29, 2018
  32. 29/37 unpack-trees: rename 'new' variablesBrandon Williams, Jan 29, 2018
  33. 21/37 imap-send: rename 'new' variablesBrandon Williams, Jan 29, 2018
  34. 20/37 http: rename 'new' variablesBrandon Williams, Jan 29, 2018
  35. 15/37 commit: rename 'new' variablesBrandon Williams, Jan 29, 2018
  36. 16/37 diff-lib: rename 'new' variableBrandon Williams, Jan 29, 2018
  37. 10/37 help: rename 'new' variablesBrandon Williams, Jan 29, 2018
  38. 13/37 remote: rename 'new' variablesBrandon Williams, Jan 29, 2018
  39. 11/37 pack-redundant: rename 'new' variablesBrandon Williams, Jan 29, 2018
  40. 12/37 reflog: rename 'new' variablesBrandon Williams, Jan 29, 2018
  41. Duy NguyenJan 30, 2018
  42. Junio C HamanoJan 30, 2018
  43. Stefan BellerJan 30, 2018
  44. Duy NguyenJan 31, 2018
  45. Stefan BellerJan 31, 2018
  46. Duy NguyenJan 31, 2018
  47. Johannes SixtJan 30, 2018
  48. 00/37 removal of some c++ keywordsBrandon Williams, Feb 14, 2018
  49. 01/37 object_info: change member name from 'typename' to 'type_name'Brandon Williams, Feb 14, 2018
  50. 02/37 object: rename function 'typename' to 'type_name'Brandon Williams, Feb 14, 2018
  51. 04/37 pack-objects: rename 'this' variablesBrandon Williams, Feb 14, 2018
  52. 03/37 blame: rename 'this' variablesBrandon Williams, Feb 14, 2018
  53. 05/37 rev-parse: rename 'this' variableBrandon Williams, Feb 14, 2018
  54. 06/37 diff: rename 'this' variablesBrandon Williams, Feb 14, 2018
  55. Junio C HamanoFeb 14, 2018
  56. Brandon WilliamsFeb 14, 2018
  57. 09/37 checkout: rename 'new' variablesBrandon Williams, Feb 14, 2018
  58. 10/37 help: rename 'new' variablesBrandon Williams, Feb 14, 2018
  59. 11/37 pack-redundant: rename 'new' variablesBrandon Williams, Feb 14, 2018
  60. 12/37 reflog: rename 'new' variablesBrandon Williams, Feb 14, 2018
  61. 15/37 commit: rename 'new' variablesBrandon Williams, Feb 14, 2018
  62. 16/37 diff-lib: rename 'new' variableBrandon Williams, Feb 14, 2018
  63. 18/37 diffcore-delta: rename 'new' variablesBrandon Williams, Feb 14, 2018
  64. 19/37 entry: rename 'new' variablesBrandon Williams, Feb 14, 2018
  65. 20/37 http: rename 'new' variablesBrandon Williams, Feb 14, 2018
  66. 21/37 imap-send: rename 'new' variablesBrandon Williams, Feb 14, 2018
  67. 22/37 line-log: rename 'new' variablesBrandon Williams, Feb 14, 2018
  68. 23/37 read-cache: rename 'new' variablesBrandon Williams, Feb 14, 2018
  69. 24/37 ref-filter: rename 'new' variablesBrandon Williams, Feb 14, 2018
  70. 26/37 split-index: rename 'new' variablesBrandon Williams, Feb 14, 2018
  71. 25/37 remote: rename 'new' variablesBrandon Williams, Feb 14, 2018
  72. 28/37 trailer: rename 'new' variablesBrandon Williams, Feb 14, 2018
  73. 29/37 unpack-trees: rename 'new' variablesBrandon Williams, Feb 14, 2018
  74. 27/37 submodule: rename 'new' variablesBrandon Williams, Feb 14, 2018
  75. 30/37 init-db: rename 'template' variablesBrandon Williams, Feb 14, 2018
  76. 33/37 environment: rename 'namespace' variablesBrandon Williams, Feb 14, 2018
  77. 34/37 wrapper: rename 'template' variablesBrandon Williams, Feb 14, 2018
  78. 35/37 tempfile: rename 'template' variablesBrandon Williams, Feb 14, 2018
  79. 36/37 trailer: rename 'template' variablesBrandon Williams, Feb 14, 2018
  80. 37/37 replace: rename 'new' variablesBrandon Williams, Feb 14, 2018
  81. 31/37 environment: rename 'template' variablesBrandon Williams, Feb 14, 2018
  82. 32/37 diff: rename 'template' variablesBrandon Williams, Feb 14, 2018
  83. 17/37 diff: rename 'new' variablesBrandon Williams, Feb 14, 2018
  84. 07/37 apply: rename 'try' variablesBrandon Williams, Feb 14, 2018
  85. 14/37 combine-diff: rename 'new' variablesBrandon Williams, Feb 14, 2018
  86. 08/37 apply: rename 'new' variablesBrandon Williams, Feb 14, 2018
  87. Stefan BellerFeb 14, 2018
  88. 13/37 remote: rename 'new' variablesBrandon Williams, Feb 14, 2018
  89. Stefan BellerFeb 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.