From: Jeff King <peff@peff.net>
Date: Thu, 07 Dec 2017 21:12:58 GMT
Subject: Re: [PATCH] diff: add tests for --relative without optional prefix value
Message-ID: <20171207211258.GB12850@sigill.intra.peff.net>
In-Reply-To: <20171207190135.28660-1-jacob.e.keller@intel.com>

On Thu, Dec 07, 2017 at 11:01:35AM -0800, Jacob Keller wrote:

> From: Jacob Keller <jacob.keller@gmail.com>
> 
> We already have tests for --relative, but they currently only test when
> a prefix has been provided. This fails to test the case where --relative
> by itself should use the current directory as the prefix.
> 
> Teach the check_$type functions to take a directory argument to indicate
> which subdirectory to run the git commands in. Add a new test which uses
> this to test --relative without a prefix value.

This looks good to me (and I slightly prefer it over Junio's for the
simplicity).

I agree on the ordering suggestion Junio made.

-Peff