Re: [PATCH 1/2] color: downgrade "always" to "auto" only for on-disk configuration

From: Jeff King <peff@peff.net>
Date: Oct 18, 2017, 05:34 UTC
Message-ID: <20171018053413.j2h63tq2qpkfev3x@sigill.intra.peff.net>
In-Reply-To: <20171017065101.ismnplaynumt5bdh@aiede.mtv.corp.google.com>

On Mon, Oct 16, 2017 at 11:51:01PM -0700, Jonathan Nieder wrote:

> > OK, so it seems we both have slight preference for the "peel back"
> > approach.  Adding Jonathan to Cc:
> 
> Which approach is "harder but right" / "peel back"?

"peel back" is reverting back to the pre-v2.14.2 state (Junio has the patches queued in jk/ref-filter-colors-fix).

Show 9 quoted lines

> I agree with the goal of making color.ui=always a synonym for auto in
> file-based config.  Peff found some problems with the warning patch
> (scripted commands produce too many warnings), which are not an issue
> for $dayjob but may be for upstream, so I see the value of holding off
> on the warning for now.
> 
> I'm also fine with "revert the proximate cause of the latest
> complaints" as a stepping stone toward making color.ui=always a
> synonym for auto in file-based config in a later release.

I do think "color.ui=always" is a foot-gun, but I wasn't happy with the number of weird hacks we ended up with in trying to fix that (like "it means one thing in the on-disk config and another thing with "git -c").

We can take it up as a topic post-release. At the very least, I think we will want to change the documentation to make it more clear that you almost certainly _don't_ want to use "always".

-Peff