Re: [PATCH 1/2] color: downgrade "always" to "auto" only for on-disk configuration
- From
Jeff King <peff@peff.net>
- Date
- Oct 12, 2017, 13:06 UTC
- Message-ID
- <20171012130649.b4tmofbvdgkevmnn@sigill.intra.peff.net>
- In-Reply-To
- <xmqqwp40zwc5.fsf@gitster.mtv.corp.google.com>
On Thu, Oct 12, 2017 at 03:58:18PM +0900, Junio C Hamano wrote:
Show 14 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > We need to be able to answer "why does '-c color.ui=always' work > > only from the command line?", but I doubt we want to actively > > encourage the use of it, though, so I dunno. > > For today's pushout, I've queued this as [PATCH 3/2] > > Thanks.. > > -- >8 -- > From: Jonathan Nieder <jrnieder@gmail.com> > Subject: color: document that "git -c color.*=always" is a bit special > Date: Wed, 11 Oct 2017 21:47:24 -0700
This looks reasonable to me to ship in v2.15. I assume we're going to leave any "git --default-color=..." options to post-release, since we're already in -rc1.
-Peff