Re: [PATCH 1/2] color: downgrade "always" to "auto" only for on-disk configuration

From: Jeff King <peff@peff.net>
Date: Oct 12, 2017, 15:12 UTC
Message-ID: <20171012151207.liri6qnqasihjg3l@sigill.intra.peff.net>
In-Reply-To: <20171012130649.b4tmofbvdgkevmnn@sigill.intra.peff.net>

On Thu, Oct 12, 2017 at 09:06:49AM -0400, Jeff King wrote:

Show 8 quoted lines

> > -- >8 --
> > From: Jonathan Nieder <jrnieder@gmail.com>
> > Subject: color: document that "git -c color.*=always" is a bit special
> > Date: Wed, 11 Oct 2017 21:47:24 -0700
> 
> This looks reasonable to me to ship in v2.15. I assume we're going to
> leave any "git --default-color=..." options to post-release, since we're
> already in -rc1.

Ah, I hadn't yet read your cover letter, since I wasn't on the cc for that.

So yes, the overall plan seems OK to me. I do have a lingering reservation that the fact that:

  git -c color.ui=always add -p

will break may come back to bite us. In particular, any such:

  git --default-color=always add -p

will run into the same problem if it is respected by plumbing. But in theory we are free to have it not be so. Arguably we could do the same for "-c color.ui", which I guess leaves us an "out" to later fix up that case (my, the kludges are certainly piling up on this one).

-Peff