Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

From: Jeff King <peff@peff.net>
Date: Aug 10, 2017, 23:10 UTC
Message-ID: <20170810231038.4s2btsotoq76atuu@sigill.intra.peff.net>
In-Reply-To: <98b14604-33f1-6d91-8c9e-ddfa0c5cb0e7@ramsayjones.plus.com>

On Fri, Aug 11, 2017 at 12:02:49AM +0100, Ramsay Jones wrote:

Show 8 quoted lines

> > But some of those things are not 1:1 mappings with normalization.  For
> > instance, --json presumably implies --only-trailers. Or are we proposing
> > to break the whole commit message down into components and output it all
> > as json?
> 
> Hmm, to me the operation wasn't so much a normalization, rather
> it was an --unfold (or maybe --un-fold ;-D). I suppose going in
> the other direction could be --fold=72, or some such.

But I really don't want callers to think of it as "unfold". I want it to be "turn this into something I can parse simply". Hence if we were to find another case where the output is irregular, I'd feel comfortable calling that a bug and fixing it (one that I suspect but haven't tested is that alternate separators probably should all be converted to colons).

> [blue is my favourite colour ... :-P ]

Yes, I'm feeling that, too. :-/

-Peff