Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

From: Jeff King <peff@peff.net>
Date: Aug 10, 2017, 07:32 UTC
Message-ID: <20170810073239.ny64rqmwb3yqbpb6@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kYqq_EhRxckM4iV=99r59Y7_y94j+-65xXLUF4y2vNUUw@mail.gmail.com>

On Wed, Aug 09, 2017 at 11:18:19AM -0700, Stefan Beller wrote:

Show 12 quoted lines

> On Wed, Aug 9, 2017 at 5:24 AM, Jeff King <peff@peff.net> wrote:
> > It can be useful to invoke interpret-trailers for the
> > primary purpose of parsing existing trailers. But in that
> > case, we don't want to apply existing ifMissing or ifExists
> > rules from the config. Let's add a special mode where we
> > avoid applying those rules. Coupled with --only-trailers,
> > this gives us a reasonable parsing tool.
> 
> I have the impression that the name is slightly misleading
> because 'only' just reduces the set. it does not enhance it.
> (Do we have a configuration that says "remove this trailer
> anytime"?)

No, I think you can only add trailers via ifExists or ifMissing. I actually called this --no-config originally, because to me it meant "do not apply config". But the processing applies also to --trailer arguments no the command line, which is how I ended up with --only-existing.

> So maybe this is rather worded as 'exact-trailers' ?

I'm not fond of that, as it's vague about which exact trailers we're talking about. I also thought of something like --verbatim, but I'd worry that would seem to conflict with --normalize.

I dunno. All of the names seem not quite descriptive enough to me.

-Peff