Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

From: Jeff King <peff@peff.net>
Date: Aug 10, 2017, 19:42 UTC
Message-ID: <20170810194251.r76pumddcchlke7c@sigill.intra.peff.net>
In-Reply-To: <CAP8UFD2kWW41NDHVKjzdL2O2=QAeEtzKEPdJW3zR-zoeTiJPgw@mail.gmail.com>

On Thu, Aug 10, 2017 at 09:39:21PM +0200, Christian Couder wrote:

Show 8 quoted lines

> > If you prefer the normalized form (and the input was line-broken in a
> > way that you don't like), then this would convert to your preferred
> > form. I agree that you could potentially want the opposite (folding long
> > lines). Perhaps something like --wrap=72.
> 
> Related to this, I wonder if people might want to "normalize" in
> different ways later. If that happens, we might regret having called
> this option "--normalize" instead of "--one-per-line" for example.

My assumption was that it would be OK to add other normalization later if it brings us closer to the "key: value" form as a standard, and it could fall under "--normalize", since that's what callers would want. And that's why I didn't want to call it something like --one-per-line.

But if you are arguing that there can be many "standards" to normalize to, I agree that's a possibility. I think we have an out by extending to "--normalize=whatever-form" in the future.

-Peff