Re: [PATCHv2 2/3] submodule-config: rename commit_sha1 to commit_or_tree

From: Brandon Williams <bmwill@google.com>
Date: Nov 22, 2016, 00:16 UTC
Message-ID: <20161122001658.GE149321@google.com>
In-Reply-To: <CAGZ79kY+0WHFgXfVmEmw7H-qwuUcWcSssRyMzg2XqsGSDq+FCw@mail.gmail.com>

On 11/21, Stefan Beller wrote:

Show 18 quoted lines

> On Mon, Nov 21, 2016 at 4:11 PM, Brandon Williams <bmwill@google.com> wrote:
> > On 11/21, Stefan Beller wrote:
> >>
> >>       switch (lookup_type) {
> >> @@ -448,7 +448,8 @@ static const struct submodule *config_from(struct submodule_cache *cache,
> >>
> >>       /* fill the submodule config into the cache */
> >>       parameter.cache = cache;
> >> -     parameter.commit_sha1 = commit_sha1;
> >> +     // todo: get the actual tree here:
> >
> > s/todo/TODO
> >
> > Makes it more clear that this is a TODO
> >
> 
> The // is more annoying here. I'll review these changes closely
> before sending out v3.

Well I prefer // to /* */ but that's not the style we use :)

-- 
Brandon Williams