git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 0/3] submodule-config: clarify/cleanup docs and header

From
Stefan Beller <sbeller@google.com>
Date
Nov 21, 2016, 23:27 UTC
Message-ID
<20161121232709.8906-1-sbeller@google.com>
replacing sb/submodule-config-cleanup

v2: addressed Jacobs concerns in patch2, fixing all occurrences of commit_sha1.

Thanks, Stefan

interdiff to v1:
diff --git a/Documentation/technical/api-submodule-config.txt b/Documentation/technical/api-submodule-config.txt
index 1df7a827ff..a91c1f085e 100644
--- a/Documentation/technical/api-submodule-config.txt
+++ b/Documentation/technical/api-submodule-config.txt
@@ -49,7 +49,7 @@ Functions
 
 `const struct submodule *submodule_from_path(const unsigned char *commit_or_tree, const char *path)`::
 
-       Lookup values for one submodule by its commit_sha1 and path.
+       Lookup values for one submodule by its commit_or_tree and path.
 
 `const struct submodule *submodule_from_name(const unsigned char *commit_or_tree, const char *name)`::


v1:
A small series that would have helped me understand the submodule config
once again.

Thanks,
Stefan

Stefan Beller (3):
  submodule config: inline config_from_{name, path}
  submodule-config: rename commit_sha1 to commit_or_tree
  submodule-config: clarify parsing of null_sha1 element

 Documentation/technical/api-submodule-config.txt | 13 ++++--
 submodule-config.c                               | 59 ++++++++++--------------
 submodule-config.h                               |  4 +-
 t/t7411-submodule-config.sh                      | 11 +++++
 4 files changed, 45 insertions(+), 42 deletions(-)
-- 
2.11.0.rc2.18.g0126045.dirty
Next: Stefan Beller
Message 1 of 12 in “[PATCHv2 0/3] submodule-config: clarify/cleanup docs and header”
  1. Stefan BellerNov 21, 2016
  2. 1/3 submodule config: inline config_from_{name, path}Stefan Beller, Nov 21, 2016
  3. Junio C HamanoNov 22, 2016
  4. 2/3 submodule-config: rename commit_sha1 to commit_or_treeStefan Beller, Nov 21, 2016
  5. Brandon WilliamsNov 22, 2016
  6. Stefan BellerNov 22, 2016
  7. Brandon WilliamsNov 22, 2016
  8. Stefan BellerNov 22, 2016
  9. Junio C HamanoNov 22, 2016
  10. Stefan BellerNov 22, 2016
  11. 3/3 submodule-config: clarify parsing of null_sha1 elementStefan Beller, Nov 21, 2016
  12. Brandon WilliamsNov 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.