Re: [PATCH 1/2] archive-tar: write extended headers for file sizes >= 8GB

From: Jeff King <peff@peff.net>
Date: Jun 23, 2016, 19:21 UTC
Message-ID: <20160623192124.GA32745@sigill.intra.peff.net>
In-Reply-To: <576A2625.8010706@web.de>

On Wed, Jun 22, 2016 at 07:46:13AM +0200, René Scharfe wrote:

> Yes, it's only useful as a debug flag, but the fact that it breaks
> highlights a (admittedly mostly theoretical) shortcoming: The code doesn't
> handle extended headers that are over the size limit as nicely as it could.
> So the test was already worth it, even if won't land in master. :)

Kind of. It was impossible to trigger in the original (and we still don't actually handle it in the revised version; we just die in xsnprintf).

But still, I'll go with the simpler thing we've discussed here. The symmetry with ustar_mtime isn't worth it, and doubly so if we just write a single pax header.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.