From: Jeff King Date: Thu, 23 Jun 2016 19:21:24 GMT Subject: Re: [PATCH 1/2] archive-tar: write extended headers for file sizes >= 8GB Message-ID: <20160623192124.GA32745@sigill.intra.peff.net> In-Reply-To: <576A2625.8010706@web.de> On Wed, Jun 22, 2016 at 07:46:13AM +0200, René Scharfe wrote: > Yes, it's only useful as a debug flag, but the fact that it breaks > highlights a (admittedly mostly theoretical) shortcoming: The code doesn't > handle extended headers that are over the size limit as nicely as it could. > So the test was already worth it, even if won't land in master. :) Kind of. It was impossible to trigger in the original (and we still don't actually handle it in the revised version; we just die in xsnprintf). But still, I'll go with the simpler thing we've discussed here. The symmetry with ustar_mtime isn't worth it, and doubly so if we just write a single pax header. -Peff