Re: [PATCH v3 1/4] t5000: test tar files that overflow ustar headers
- From
Jeff King <peff@peff.net>
- Date
- Jun 24, 2016, 16:46 UTC
- Message-ID
- <20160624164603.GA13789@sigill.intra.peff.net>
- In-Reply-To
- <576D621F.1030000@kdbg.org>
On Fri, Jun 24, 2016 at 06:38:55PM +0200, Johannes Sixt wrote:
Show 13 quoted lines
> Am 24.06.2016 um 01:20 schrieb Jeff King:
> > +# We expect git to die with SIGPIPE here (otherwise we
> > +# would generate the whole 64GB).
> > +test_expect_failure BUNZIP 'generate tar with huge size' '
> > + {
> > + git archive HEAD
> > + echo $? >exit-code
> > + } | head -c 4096 >huge.tar &&
> > + echo 141 >expect &&
> > + test_cmp expect exit-code
>
> It's going to be 269 with ksh, and who-knows-what on Windows (due to lack of
> SIGPIPE - I haven't tested this, yet).Thanks, I meant to ask about that. We do a workaround in t0005, but we _don't_ do it in the new sigpipe handling for test_must_fail. Is the latter just broken, too?
-Peff