Re: [PATCH 1/2] archive-tar: write extended headers for file sizes >= 8GB

From: Jeff King <peff@peff.net>
Date: Jun 21, 2016, 20:57 UTC
Message-ID: <20160621205720.GA4747@sigill.intra.peff.net>
In-Reply-To: <robbat2-20160621T185126-722667990Z@orbis-terrarum.net>

On Tue, Jun 21, 2016 at 07:44:55PM +0000, Robin H. Johnson wrote:

Show 8 quoted lines

> On Thu, Jun 16, 2016 at 12:37:33AM -0400,  Jeff King wrote:
> > We could ship just the resulting compressed object data as a
> > loose object, but even that takes 64MB. So sadly, this code
> > path remains untested in the test suite.
> Additionally compress the object data, and insert it for the purpose of
> testing? It's still an expensive test time-wise, but repeated
> gzip compression on zeros does still help; to that end, here's the
> pieces to add a testcase while only being <9KiB.

Interesting idea. With bzip2 it actually drops to about 600 bytes (I suspect we could get it even smaller by writing a custom program to generate it, but it's diminishing returns).

I think there are some other portability issues, though (like does the receiving tar actually support 64GB sizes).

-Peff