git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 1/1] format-patch: add an option to record base tree info

From
DCDan Carpenter <dan.carpenter@oracle.com>
Date
Feb 23, 2016, 13:31 UTC
Message-ID
<20160223133135.GF5273@mwanda>
In-Reply-To
<20160223120015.GA10488@wfg-t540p.sh.intel.com>

Blergh... You want it machine readable and I want it human readable. I don't care so much about the cover letter but for the first patch then I really want something minimal (one line) and human readable.

base tree/branch: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master base commit: afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc base patch-id: a849260a843115dbac4b1a330d44256ee6b16d7b base patch-subject: Linux 4.4 base tag: v4.4

To me that looks like an unparseable wall of text. My version of that is:

Applies-to: afd2ff9b7e1b+ origin

As a human all I really want to know is the tree to apply this to. If it doesn't apply then I don't debug it, I just send an automatic note "This doesn't apply to staging-next. Please redo."

I think that Applies-to is a better name and also that grepping for "^base " is less reliable than grepping for ^Applies-to.

I used "origin" because that's the name in Next/Trees. The + means private patches are applied. That's what we already do in naming the kernel. If the + matters, then I would include a cover letter.

I have no idea what a "base patch-id" is so that doesn't work at all.
Including the tag is just duplicative since we already have the hash.

In my email, I proposed that we list all the other private patches in a cover letter, but I think you are saying that we only need to know the most recent private patch? Another idea would be to list them newest to oldest (git log order instead of email order) in the cover letter.

Btw, I always work against linux-next and Dave M is always getting annoyed with me for not marking which patches go to net and which go to net-next. I don't use git format-patch, but I will probably start using "Applies-to: net" or "Applies-to: net-next".

regards, dan carpenter

Previous: Fengguang WuNext: Fengguang Wu
Message 12 of 29 in “Add an option to git-format-patch to record base tree info”
  1. 0/1 Add an option to git-format-patch to record base tree infoXiaolong Ye, Feb 22, 2016
  2. 1/1 format-patch: add an option to record base tree infoXiaolong Ye, Feb 22, 2016
  3. Junio C HamanoFeb 22, 2016
  4. Jacob KellerFeb 22, 2016
  5. Fengguang WuFeb 23, 2016
  6. Junio C HamanoFeb 23, 2016
  7. Fengguang WuFeb 23, 2016
  8. H. Peter AnvinFeb 23, 2016
  9. Fengguang WuFeb 23, 2016
  10. Dan CarpenterFeb 23, 2016
  11. Fengguang WuFeb 23, 2016
  12. Dan CarpenterFeb 23, 2016
  13. Fengguang WuFeb 24, 2016
  14. Junio C HamanoFeb 24, 2016
  15. Fengguang WuFeb 24, 2016
  16. Junio C HamanoFeb 24, 2016
  17. Junio C HamanoFeb 23, 2016
  18. Eric W. BiedermanFeb 23, 2016
  19. Junio C HamanoFeb 23, 2016
  20. H. Peter AnvinFeb 23, 2016
  21. Eric W. BiedermanFeb 23, 2016
  22. H. Peter AnvinFeb 24, 2016
  23. Stefan BellerFeb 23, 2016
  24. Michael J GruberFeb 24, 2016
  25. Junio C HamanoFeb 24, 2016
  26. Fengguang WuFeb 24, 2016
  27. Fengguang WuFeb 24, 2016
  28. Eric W. BiedermanFeb 23, 2016
  29. Fengguang WuFeb 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.