Re: [RFC/PATCH 1/1] format-patch: add an option to record base tree info
- From
- Fengguang Wu <fengguang.wu@intel.com>
- Date
- Feb 23, 2016, 09:32 UTC
- Message-ID
- <20160223093221.GC7150@wfg-t540p.sh.intel.com>
- In-Reply-To
- <56CC2507.7060300@zytor.com>
On Tue, Feb 23, 2016 at 01:23:19AM -0800, H. Peter Anvin wrote:
Show 12 quoted lines
> On 02/23/16 01:17, Fengguang Wu wrote: > > > > However we are facing a new situation: in test robot POV, IMHO there > > are values to test exactly the same tree as the patch submitter. > > Otherwise the robot risks > > > > - false negative: failing to apply and test some patches > > - false positive: sending wrong bug reports due to guessed wrong base tree > > > > Wouldn't the important part here be the git hash, rather than the tree? > If you have the same hash then it by definition is the same contents?
Yes. Sorry for the partial wording! We should be talking about the same thing: the hash of the tree object. The commit SHA1 will also do the work.
Thanks, Fengguang