git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 0/1] Add an option to git-format-patch to record base tree info

From
Xiaolong Ye <xiaolong.ye@intel.com>
Date
Feb 22, 2016, 02:58 UTC
Message-ID
<1456109938-8568-1-git-send-email-xiaolong.ye@intel.com>
Hi, 

I am a developer of 0-Day kernel test infrastructure(It is a service and test framework for automated regression-testing that intercepts linux kernel development at its early stages [1]), and as proposed by developers in ksummit-discuss, we have implemented a framework to test all patches sent to LKML, it could help us to find out potential build/boot/regression errors as early as possible.

In order to test LKML patches on their correct trees, we need to know the corresponding base tree info, such as git url, branch, base commit id, etc, currently we did some guess works and it may apply patches to the wrong base trees, leading to undesirable false positives.

The only clean solution is for the developers to include these base tree info in their first [PATCH] email, so we propose to add an option "--base-tree-info" to git-format-patch to record these info in cover letter or the first patch (put it between the "---" marker line and the actual diff), we believe it would also be useful for maintainers who use git to manage their projects.

The initial implementation only record the base(parent) commit SHA1 of the first patch. Here is the example:

1) with cover letter
you could see the commit id at the bottom of the message.
2) without cover letter
	Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
	---
	 builtin/log.c | 17 +++++++++++++++++
	 diff.c        |  4 ++++
	 diff.h        |  3 ++-
	 revision.h    |  1 +
	 4 files changed, 24 insertions(+), 1 deletion(-)
	base commit: 0233b800c838ddda41db318ee396320b3c21a560
	diff --git a/builtin/log.c b/builtin/log.c
	index 0d738d6..49fe8c2 100644
	--- a/builtin/log.c
	+++ b/builtin/log.c

What do you think? Any review comments about this patch or any suggestions to us would be greatly appreciated.

[1] https://01.org/lkp/documentation/0-day-test-service

Thanks, Xiaolong.

Xiaolong Ye (1):
  format-patch: add an option to record base tree info
 builtin/log.c | 18 ++++++++++++++++++
 diff.c        |  4 ++++
 diff.h        |  3 ++-
 revision.h    |  1 +
 4 files changed, 25 insertions(+), 1 deletion(-)
base commit: 0233b800c838ddda41db318ee396320b3c21a560
-- 
2.7.1.340.gf1cebb4
Next: Xiaolong Ye
Message 1 of 29 in “Add an option to git-format-patch to record base tree info”
  1. 0/1 Add an option to git-format-patch to record base tree infoXiaolong Ye, Feb 22, 2016
  2. 1/1 format-patch: add an option to record base tree infoXiaolong Ye, Feb 22, 2016
  3. Junio C HamanoFeb 22, 2016
  4. Jacob KellerFeb 22, 2016
  5. Fengguang WuFeb 23, 2016
  6. Junio C HamanoFeb 23, 2016
  7. Fengguang WuFeb 23, 2016
  8. H. Peter AnvinFeb 23, 2016
  9. Fengguang WuFeb 23, 2016
  10. Dan CarpenterFeb 23, 2016
  11. Fengguang WuFeb 23, 2016
  12. Dan CarpenterFeb 23, 2016
  13. Fengguang WuFeb 24, 2016
  14. Junio C HamanoFeb 24, 2016
  15. Fengguang WuFeb 24, 2016
  16. Junio C HamanoFeb 24, 2016
  17. Junio C HamanoFeb 23, 2016
  18. Eric W. BiedermanFeb 23, 2016
  19. Junio C HamanoFeb 23, 2016
  20. H. Peter AnvinFeb 23, 2016
  21. Eric W. BiedermanFeb 23, 2016
  22. H. Peter AnvinFeb 24, 2016
  23. Stefan BellerFeb 23, 2016
  24. Michael J GruberFeb 24, 2016
  25. Junio C HamanoFeb 24, 2016
  26. Fengguang WuFeb 24, 2016
  27. Fengguang WuFeb 24, 2016
  28. Eric W. BiedermanFeb 23, 2016
  29. Fengguang WuFeb 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.