Re: [PATCH v4 18/21] column: read lines with strbuf_getline()

From: Jeff King <peff@peff.net>
Date: Jan 15, 2016, 20:43 UTC
Message-ID: <20160115204325.GH11301@sigill.intra.peff.net>
In-Reply-To: <1452815916-6447-19-git-send-email-gitster@pobox.com>

On Thu, Jan 14, 2016 at 03:58:33PM -0800, Junio C Hamano wrote:

> Multiple lines read here are concatenated on a single line to form a
> multi-column output line.  We do not want to have a CR at the end,
> even if the input file consists of CRLF terminated lines.

Hrm. I suspect this is OK in practice, though "git column" can technically receive unbounded input from the user. We don't specify in the documentation that it must be text, but I guess it's somewhat implied by the use of the word "line".

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.