Re: [PATCH v2 01/17] strbuf: make strbuf_getline_crlf() global
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 4, 2016, 19:17 UTC
- Message-ID
- <xmqqvb79nogx.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1601041255110.14434@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 18 quoted lines
> Hi Junio, > > On Wed, 16 Dec 2015, Junio C Hamano wrote: > >> Often we read "text" files that are supplied by the end user >> (e.g. commit log message that was edited with $GIT_EDITOR upon >> 'git commit -e'), and in some environments lines in a text file >> are terminated with CRLF. Existing strbuf_getline() knows to read >> a single line and then strip the terminating byte from the result, >> but it is handy to have a version that is more tailored for a "text" >> input that takes both '\n' and '\r\n' as line terminator (aka >> <newline> in POSIX lingo) and returns the body of the line after >> stripping <newline>. >> >> Recently reimplemented "git am" uses such a function implemented >> privately; move it to strbuf.[ch] and make it available for others. > > ... While at it, we fix the formatting of the strbuf_getline() function.
Yeah right; I think it is obvious from the patch text, but while at it, I'll amend the log message ;-)
Thanks.