From: Jeff King Date: Fri, 15 Jan 2016 20:43:25 GMT Subject: Re: [PATCH v4 18/21] column: read lines with strbuf_getline() Message-ID: <20160115204325.GH11301@sigill.intra.peff.net> In-Reply-To: <1452815916-6447-19-git-send-email-gitster@pobox.com> On Thu, Jan 14, 2016 at 03:58:33PM -0800, Junio C Hamano wrote: > Multiple lines read here are concatenated on a single line to form a > multi-column output line. We do not want to have a CR at the end, > even if the input file consists of CRLF terminated lines. Hrm. I suspect this is OK in practice, though "git column" can technically receive unbounded input from the user. We don't specify in the documentation that it must be text, but I guess it's somewhat implied by the use of the word "line". -Peff