Re: [PATCH v2 0/6] Make "local" orthogonal to date format
- From
Jeff King <peff@peff.net>
- Date
- Sep 2, 2015, 08:05 UTC
- Message-ID
- <20150902080529.GA19248@sigill.intra.peff.net>
- In-Reply-To
- <20150902074826.GK30659@serenity.lan>
On Wed, Sep 02, 2015 at 08:48:26AM +0100, John Keeping wrote:
Show 7 quoted lines
> On Tue, Sep 01, 2015 at 06:44:31PM -0400, Jeff King wrote: > > [1] I do think the error message for "relative-local is nonsense" could > > perhaps be more explanatory, but I couldn't come up with any better > > wording. But if you have ideas, feel free to switch it. > > My only suggestion would be to reuse the "unknown date format: %s" > message and avoid having a special message in this case.
Heh, that was what I was trying to avoid. I wanted to avoid "I do not understand our request" and have it more like "I understand what you're _trying_ to do, but it doesn't make sense".
I guess "relative dates do not depend on timezones, so -local is meaningless" would be the closest thing.
I don't think it is that big a deal whichever way we go, though.
-Peff