[PATCH 0/4] error cleanups in lock_ref_sha1_basic

From: Jeff King <peff@peff.net>
Date: Nov 19, 2014, 01:35 UTC
Message-ID: <20141119013532.GA861@peff.net>
In-Reply-To: <1416359597-15481-1-git-send-email-sbeller@google.com>

On Tue, Nov 18, 2014 at 05:13:17PM -0800, Stefan Beller wrote:

Show 12 quoted lines

> From: Ronnie Sahlberg <sahlberg@google.com>
> 
> Change lock_ref_sha1_basic to return an error instead of dying,
> when we fail to lock a file during a transaction. This function is
> only called from transaction_commit() and it knows how to handle
> these failures.
> 
> [sb: This was part of a larger patch series, cherry-picked to master]
> 
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>

I think this is a good thing to do. I independently wrote the same patch recently, along with some other cleanups. Here's the series I ended up with (I added Ronnie as the author of the final one, which replaces this; even though my discovery was independent, he wrote it first :) ).

  [1/4]: error: save and restore errno
  [2/4]: lock_ref_sha1_basic: simplify errno handling
  [3/4]: lock_ref_sha1_basic: simplify error code path
  [4/4]: lock_ref_sha1_basic: do not die on locking errors

-Peff