git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/9] replace signal() with sigaction()

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
Jun 2, 2014, 14:39 UTC
Message-ID
<20140602143905.GA2048@hudson.localdomain>
In-Reply-To
<538C5FD9.1010706@viscovery.net>
Hannes,
On Mon, Jun 02, 2014 at 01:28:25PM +0200, Johannes Sixt wrote:
> Am 6/1/2014 20:10, schrieb Jeremiah Mahler:
> > This is version 3 of the patch set to convert signal(2) to sigaction(2)
> > (previous discussion [1]).
> > 
...
Show 10 quoted lines
> >   sigchain.c: replace signal() with sigaction()
> 
> The series without patch 9/9 works on Windows so far.
> 
> Without patch patch 9/9 and a more complete implementation of sigaction in
> compat/mingw.c the series misses its goal. But even if you complete it, it
> is IMHO only code churn without practical merits.
> 
> -- Hannes
>

You are right, I missed the case where the old signal was used, as is done in sigchain.c. Sorry about that.

Thanks again for looking at my patch.
-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
Previous: Johannes SixtNext: Junio C Hamano
Message 13 of 15 in “replace signal() with sigaction()”
  1. 0/9 replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  2. 1/9 compat/mingw.c: expand MinGW support for sigactionJeremiah Mahler, Jun 1, 2014
  3. Johannes SixtJun 2, 2014
  4. 2/9 connect.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  5. 3/9 progress.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  6. 4/9 write_or_die.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  7. 5/9 daemon.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  8. 6/9 builtin/log.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  9. 7/9 builtin/merge-index.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  10. 8/9 builtin/verify-tag.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  11. 9/9 sigchain.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  12. Johannes SixtJun 2, 2014
  13. Jeremiah MahlerJun 2, 2014
  14. Junio C HamanoJun 2, 2014
  15. Jeremiah MahlerJun 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.